Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link Schema #44

Open
BANANAPEEL202 opened this issue Oct 26, 2024 · 1 comment
Open

Link Schema #44

BANANAPEEL202 opened this issue Oct 26, 2024 · 1 comment
Assignees

Comments

@BANANAPEEL202
Copy link
Collaborator

BANANAPEEL202 commented Oct 26, 2024

update the schemas for the selected file

currently roadblocked by the fact that mock server does not seem to send that information

  • FIX THE LAYOUT AS WELL --> should not look like this
Screenshot 2024-11-03 at 7 03 23 PM
@aesteri aesteri changed the title Link Schema and File Preview Images Link Schema Nov 6, 2024
@BANANAPEEL202
Copy link
Collaborator Author

BANANAPEEL202 commented Nov 15, 2024

Jotting down some concerns/questions:

the new MCAPFileInformation seems to be missing a car model field
real server doesn't implement notes ig (FIXED?)
how do we want to choose which filename to display in the table/preview card since there are multiple file names now? the first one? (FIRST ONE FOR NOW)
real server uses /api/v2/mcaps. mock server uses /api/v2/mcap/get??
mock server/sample data needs to use unique IDs, otherwise the select function gets fucked
wtf does "getFileNameWithoutExtension" in DataTable.tsx do
rn we're only loading the lat-long image

this branch will definitely not work in production. Too many discrepancies between mock and real server

@SreeDan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

1 participant