Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't allow replies with a broader set of permissions than the annotation they're replying to #1616

Open
mkdir-washington-edu opened this issue Dec 12, 2024 · 0 comments

Comments

@mkdir-washington-edu
Copy link

This is solution A from this document: #1602.

The Problem
Students can create shared (annotation.shared = TRUE) replies to unshared (annotation.shared = FALSE) annotations. These shared replies are counted in our email digest and by our Auto-grading feature. They're also not visible to anyone except the user who owns the parent unshared annotation.

The Solution
While there are other potential solutions that cover various edge cases of the main problem, we predict that the largest source of this phenomenon is students creating their own unshared annotations (such as highlights) and created shared replies to them. This will stop that practice, which is the correct first step.

At the moment a reply is being posted, check the shared status of the reply and of the parent annotation. Do not allow users to save shared replies if the parent annotation is unshared.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant