Merge pull request #8 from hypnoglow/add-linter

Add linter

.github/workflows/main.yaml

@@ -26,6 +26,11 @@ jobs:
           go mod download
           go mod vendor
 
+      - name: Run linters
+        uses: golangci/golangci-lint-action@v2
+        with:
+          version: v1.31
+
       - name: Build
         run: |
           go build -o ./bin/terraform-provider-oryhydra

.golangci.yml

@@ -0,0 +1,48 @@
+run:
+  concurrency: 4
+  timeout: 5m
+
+linters:
+  disable-all: true
+  enable:
+    - deadcode
+    - depguard
+    - errcheck
+    - gci
+    - goconst
+    - gocritic
+    - gocyclo
+    - gofmt
+    - goimports
+    - golint
+    - gosec
+    - gosimple
+    - govet
+    - ineffassign
+    - interfacer
+    - maligned
+    - misspell
+    - nakedret
+    # - prealloc
+    - scopelint
+    - staticcheck
+    - structcheck
+    - stylecheck
+    - typecheck
+    - unconvert
+    - unparam
+    - unused
+    - varcheck
+
+linters-settings:
+  goimports:
+    local-prefixes: github.com/hypnoglow/terraform-provider-oryhydra
+
+issues:
+  exclude-rules:
+    - linters:
+        - errcheck
+      text: Error return value of `d.Set` is not checked
+    - linters:
+        - gocritic
+      text: ^singleCaseSwitch

Makefile

@@ -5,3 +5,7 @@ build:
 .PHONY: prepare-examples
 prepare-examples:
 	@ln -s $(shell pwd)/bin/terraform-provider-oryhydra ./examples/oryhydra_oauth2_client/terraform-provider-oryhydra
+
+.PHONY: lint
+lint:
+	@golangci-lint run

oryhydra/logger.go

@@ -35,10 +35,6 @@ type logger interface {
 
 type nopLogger struct{}
 
-func (n nopLogger) Print(v ...interface{}) {
-	return
-}
+func (n nopLogger) Print(v ...interface{}) {}
 
-func (n nopLogger) Printf(format string, v ...interface{}) {
-	return
-}
+func (n nopLogger) Printf(format string, v ...interface{}) {}