From e7031b6f6494d3929f3eb632e6030f90aaf8cf33 Mon Sep 17 00:00:00 2001 From: Zied Dahmani Date: Wed, 20 Nov 2024 13:14:18 +0100 Subject: [PATCH] fix: add scroll to dao lists --- .../creation/components/dao_selection_view.dart | 4 ++-- .../filter/components/filter_proposals_view.dart | 10 ++++------ 2 files changed, 6 insertions(+), 8 deletions(-) diff --git a/lib/ui/proposals/creation/components/dao_selection_view.dart b/lib/ui/proposals/creation/components/dao_selection_view.dart index a613c84b..8e4f1481 100644 --- a/lib/ui/proposals/creation/components/dao_selection_view.dart +++ b/lib/ui/proposals/creation/components/dao_selection_view.dart @@ -45,8 +45,8 @@ class _DaoSelectionViewState extends State { height: MediaQuery.sizeOf(context).height, color: context.isDarkMode ? HyphaColors.darkBlack : HyphaColors.offWhite, padding: const EdgeInsets.symmetric(horizontal: 20), - child: Column( - crossAxisAlignment: CrossAxisAlignment.start, + child: ListView( + physics: const ClampingScrollPhysics(), children: [ const SizedBox(height: 20), Text( diff --git a/lib/ui/proposals/filter/components/filter_proposals_view.dart b/lib/ui/proposals/filter/components/filter_proposals_view.dart index f7adca00..72188127 100644 --- a/lib/ui/proposals/filter/components/filter_proposals_view.dart +++ b/lib/ui/proposals/filter/components/filter_proposals_view.dart @@ -20,6 +20,7 @@ class FilterProposalsView extends StatelessWidget { return Scaffold( backgroundColor: context.isDarkMode ? HyphaColors.darkBlack : HyphaColors.offWhite, appBar: AppBar( + scrolledUnderElevation: 0, title: const Text('Filter Proposals'), ), body: BlocBuilder( @@ -27,8 +28,8 @@ class FilterProposalsView extends StatelessWidget { return HyphaBodyWidget(pageState: state.pageState, success: (context) { return Padding( padding: const EdgeInsets.symmetric(horizontal: 26.0, vertical: 20), - child: Column( - crossAxisAlignment: CrossAxisAlignment.start, + child: ListView( + physics: const ClampingScrollPhysics(), children: [ Text( 'Select Proposal Status', @@ -70,16 +71,13 @@ class FilterProposalsView extends StatelessWidget { )); }, ), - const Spacer(), + const SizedBox(height: 20), HyphaAppButton( title: 'SAVE FILTERS', onPressed: () { filterProposalsBloc.add(FilterProposalsEvent.saveFilters(filterProposalsBloc.selectedStatusIndexNotifier.value == 0 ? FilterStatus.active : FilterStatus.past)); }, ), - const SizedBox( - height: 20, - ) ], ), );