New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Websocket ping thread never ends #24

Open

feltz opened this issue Mar 6, 2024 · 0 comments · May be fixed by #73

feltz commented Mar 6, 2024

In websocket_manager.py, you could add the following so that the close of websocket will endthe thread too.

if self.ws.keep_running:
    self.ws.send(json.dumps({"method": "ping"}))
else:
    break

within:

    def send_ping(self):
        while True:
            time.sleep(50)
            logging.debug("Websocket sending ping")
            self.ws.send(json.dumps({"method": "ping"}))

The text was updated successfully, but these errors were encountered:

JmPotato linked a pull request

that will close this issue

Add graceful shutdown logic for WebSocket #73

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment