Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VERKLE] Implement Verkle #6961

Draft
wants to merge 86 commits into
base: main
Choose a base branch
from
Draft

[VERKLE] Implement Verkle #6961

wants to merge 86 commits into from

Conversation

matkt
Copy link
Contributor

@matkt matkt commented Apr 17, 2024

PR description

use : https://github.com/hyperledger/besu-verkle-trie

Fixed Issue(s)

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

matkt added 30 commits November 28, 2023 11:37
Signed-off-by: Karim TAAM <[email protected]>
Signed-off-by: Karim TAAM <[email protected]>
Signed-off-by: Karim TAAM <[email protected]>
Signed-off-by: Karim Taam <[email protected]>
Signed-off-by: Karim Taam <[email protected]>
Signed-off-by: Karim Taam <[email protected]>
Signed-off-by: Karim Taam <[email protected]>
Signed-off-by: Karim Taam <[email protected]>
Signed-off-by: Karim Taam <[email protected]>
Signed-off-by: Karim Taam <[email protected]>
Signed-off-by: Karim Taam <[email protected]>
Signed-off-by: Karim Taam <[email protected]>
Signed-off-by: Karim Taam <[email protected]>
Signed-off-by: Karim Taam <[email protected]>
Signed-off-by: Karim Taam <[email protected]>
Signed-off-by: Karim Taam <[email protected]>
Signed-off-by: Karim Taam <[email protected]>
Signed-off-by: Karim Taam <[email protected]>
Signed-off-by: Karim Taam <[email protected]>
Signed-off-by: Karim Taam <[email protected]>
Signed-off-by: Karim Taam <[email protected]>
Signed-off-by: Karim Taam <[email protected]>
lu-pinto and others added 9 commits October 1, 2024 10:37
…EAF (#7681)

* Fix storing BASIC_DATA_LEAF values in Big endian order

Signed-off-by: Luis Pinto <[email protected]>

* Write code hash on account creation in all cases

Signed-off-by: Luis Pinto <[email protected]>

---------

Signed-off-by: Luis Pinto <[email protected]>
Signed-off-by: Karim Taam <[email protected]>
Signed-off-by: Karim Taam <[email protected]>
…7751)

* Fix BASIC_DATA_LEAF update on account with existing code size value

Signed-off-by: Luis Pinto <[email protected]>

* fixup! Fix BASIC_DATA_LEAF update on account with existing code size value

 grab current code from accumulator instead

Signed-off-by: Luis Pinto <[email protected]>

---------

Signed-off-by: Luis Pinto <[email protected]>
Signed-off-by: Karim Taam <[email protected]>
Signed-off-by: Karim Taam <[email protected]>
matkt and others added 5 commits November 4, 2024 11:36
Signed-off-by: Karim Taam <[email protected]>
* Move EIP-4762 gas charging for contract account creation from code successfully created to transaction start

Signed-off-by: Luis Pinto <[email protected]>

* fixup! Move EIP-4762 gas charging for contract account creation from code successfully created to transaction start

 compact code for debug printing witness gas schedule

Signed-off-by: Luis Pinto <[email protected]>

* fixup! Move EIP-4762 gas charging for contract account creation from code successfully created to transaction start

 update verkle reference tests build

Signed-off-by: Luis Pinto <[email protected]>

---------

Signed-off-by: Luis Pinto <[email protected]>
Signed-off-by: Karim Taam <[email protected]>
@matkt matkt closed this Nov 28, 2024
@matkt matkt deleted the verkle branch November 28, 2024 15:45
@matkt matkt restored the verkle branch November 28, 2024 16:23
@matkt matkt reopened this Nov 28, 2024
@lu-pinto
Copy link
Contributor

lu-pinto commented Jan 7, 2025

PragueBlockHashProcessor is still using the system contract storage address of 0xfffffffffffffffffffffffffffffffffffffffe for the moment to be able to sync with verkle testnet. But has already changed in main and the EIP itself https://eips.ethereum.org/EIPS/eip-2935. The address change should not be brought into main along with changes to EvmSpecToolTests to make them pass on the verkle branch.

lu-pinto and others added 2 commits January 8, 2025 15:40
* merge main@b3b33da540 into verkle@1412aefd8b

Signed-off-by: Luis Pinto <[email protected]>

* make gradle dependency verification on verkle lenient

Signed-off-by: Luis Pinto <[email protected]>

* fix invalid verkle account creation from UpdateTrackingAccount

Signed-off-by: Karim Taam <[email protected]>

* Fix RocksDBKeyValueStorageFactoryTests

Signed-off-by: Luis Pinto <[email protected]>

* fix EvmSpecToolTests

Signed-off-by: Luis Pinto <[email protected]>

---------

Signed-off-by: Luis Pinto <[email protected]>
Signed-off-by: Karim Taam <[email protected]>
Co-authored-by: Karim Taam <[email protected]>
Signed-off-by: Luis Pinto <[email protected]>
* EIP-7709 Implement gas costs for BLOCKHASH implementation with system contract

Signed-off-by: Luis Pinto <[email protected]>

* fixup! EIP-7709 Implement gas costs for BLOCKHASH implementation with system contract

 forgot to add code from previous tip

Signed-off-by: Luis Pinto <[email protected]>

* fixup! EIP-7709 Implement gas costs for BLOCKHASH implementation with system contract

 reimplement insufficient gas cost case with null

Signed-off-by: Luis Pinto <[email protected]>

---------

Signed-off-by: Luis Pinto <[email protected]>
* Fix javadoc issues

Signed-off-by: Luis Pinto <[email protected]>

* Fix plugin-api checksum check

Signed-off-by: Luis Pinto <[email protected]>

* fix CodeDelegationTransactionAcceptanceTest

Signed-off-by: Luis Pinto <[email protected]>

---------

Signed-off-by: Luis Pinto <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants