-
Notifications
You must be signed in to change notification settings - Fork 871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optionally load jemalloc #7047
Labels
Comments
@amsmota I think it would be great if you could do a PR for this |
I will. Thanks... 👍
|
amsmota
added a commit
to Citi/besu
that referenced
this issue
May 14, 2024
Signed-off-by: Antonio Mota <[email protected]>
8 tasks
amsmota
added a commit
to Citi/besu
that referenced
this issue
May 14, 2024
Signed-off-by: Antonio Mota <[email protected]>
Hi @macfarla, I opened the PR already, see above. Thanks. 👍 |
amsmota
added a commit
to Citi/besu
that referenced
this issue
May 18, 2024
… after review Signed-off-by: Antonio Mota <[email protected]>
non-fungible-nelson
added
enhancement
New feature or request
good first issue
Good for newcomers
labels
Jun 4, 2024
amsmota
added a commit
to Citi/besu
that referenced
this issue
Jun 14, 2024
… entry to CHANGELOG Signed-off-by: Antonio Mota <[email protected]>
8 tasks
Hi @macfarla, @non-fungible-nelson, I merged the current main branch into my branch, and it created a new PR (see below). Can youse please review it and hopefully approve it? Many thanks. Cheers. |
usmansaleem
pushed a commit
that referenced
this issue
Nov 13, 2024
* Implementing Issue #7047 - Optionally load jemalloc Signed-off-by: Antonio Mota <[email protected]> * Implementing Issue #7047 - Optionally load jemalloc Signed-off-by: Antonio Mota <[email protected]> * Implementing Issue #7047 - Optionally load jemalloc: fixes after review Signed-off-by: Antonio Mota <[email protected]> * Implementing Issue #7047 - Optionally load jemalloc: added entry to CHANGELOG Signed-off-by: Antonio Mota <[email protected]> * Changes after review Signed-off-by: Antonio Mota <[email protected]> * Added env var check in unix script Signed-off-by: Antonio Mota <[email protected]> * Improved code and script, build and tested Signed-off-by: amsmota <[email protected]> * Improved code and script, build and tested Signed-off-by: amsmota <[email protected]> --------- Signed-off-by: Antonio Mota <[email protected]> Signed-off-by: amsmota <[email protected]>
JanetMo
pushed a commit
to JanetMo/besu
that referenced
this issue
Nov 17, 2024
* Implementing Issue hyperledger#7047 - Optionally load jemalloc Signed-off-by: Antonio Mota <[email protected]> * Implementing Issue hyperledger#7047 - Optionally load jemalloc Signed-off-by: Antonio Mota <[email protected]> * Implementing Issue hyperledger#7047 - Optionally load jemalloc: fixes after review Signed-off-by: Antonio Mota <[email protected]> * Implementing Issue hyperledger#7047 - Optionally load jemalloc: added entry to CHANGELOG Signed-off-by: Antonio Mota <[email protected]> * Changes after review Signed-off-by: Antonio Mota <[email protected]> * Added env var check in unix script Signed-off-by: Antonio Mota <[email protected]> * Improved code and script, build and tested Signed-off-by: amsmota <[email protected]> * Improved code and script, build and tested Signed-off-by: amsmota <[email protected]> --------- Signed-off-by: Antonio Mota <[email protected]> Signed-off-by: amsmota <[email protected]> Signed-off-by: Marlene Marz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
As an Developer/Devops/Tester, I want to enable/disable the use of jemalloc when starting Besu so that I can easily test performance with/without jemalloc and be able to start without jemalloc if there is a memory issue on startup.
Acceptance Criteria
Versions
Implementation
I was able to implement and test this feature by reusing the
BESU_USING_JEMALLOC
env var, with changes in the initial besu start script and a few lines in ConfigurationOverviewBuilder.If set,
BESU_USING_JEMALLOC=true
will load jemalloc, if set to anything else it won't. IfBESU_USING_JEMALLOC
is not set at all it'll load it too (that is the existing behavior).If enough people think this is useful I am ready to create a PR.
The text was updated successfully, but these errors were encountered: