Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make all tasks switching tasks #5271

Closed
pinges opened this issue Mar 28, 2023 · 4 comments
Closed

Make all tasks switching tasks #5271

pinges opened this issue Mar 28, 2023 · 4 comments

Comments

@pinges
Copy link
Contributor

pinges commented Mar 28, 2023

Description

At the moment we have "switching" tasks, that go through the list of our peers when it is necessary to retry a task, and we have "retrying" tasks, that select the "best" peer every time we need to retry that task. As the best peer was selected the first time this task was called, there is a very good chance that we are selecting the same peer to retry that task. It makes more sense to select a different peer, which the "switching" tasks do.

Make sure that all tasks behave the same when getting a "useless" response. At the moment we have cases where we are returning an Optional.empty() and cases where we throw a IncompleteResultsException.

Make sure that we are doing the switch to another peer when needed. I think that we are not always doing that for "useless" responses.

There are tasks that we want to call with a specific peer, like getting a block or transaction when it was announced by one of our peers. We need to make sure that this can still happen.

Acceptance Criteria

  • There are no 'retrying' tasks left
@fab-10
Copy link
Contributor

fab-10 commented May 30, 2023

this is partially implemented in #5508 and #5509

@non-fungible-nelson
Copy link
Contributor

Need a status on this ticket

@Matilda-Clerke
Copy link
Contributor

@non-fungible-nelson
Copy link
Contributor

Closing in favor of #7602

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants