-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore!: simplify peer id parsing #5228
Merged
0x009922
merged 1 commit into
hyperledger-iroha:main
from
mversic:simplify_peers_in_conifg
Nov 12, 2024
Merged
chore!: simplify peer id parsing #5228
0x009922
merged 1 commit into
hyperledger-iroha:main
from
mversic:simplify_peers_in_conifg
Nov 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mversic
requested review from
s8sato,
SamHSmith,
outoftardis,
0x009922,
DCNick3 and
dima74
as code owners
November 11, 2024 12:39
github-actions
bot
added
the
config-changes
Changes in configuration and start up of the Iroha
label
Nov 11, 2024
mversic
force-pushed
the
simplify_peers_in_conifg
branch
6 times, most recently
from
November 12, 2024 07:54
20e9408
to
c803822
Compare
0x009922
requested changes
Nov 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When will we stop breaking configuration... @BAStos525 please take a note.
Also, please, fill the PR description appropriately, at least the migration guide. It directly affects public API. |
mversic
force-pushed
the
simplify_peers_in_conifg
branch
from
November 12, 2024 08:39
c803822
to
38af9fd
Compare
mversic
changed the title
chore: simplify peers serialized form in the configuration
chore!: simplify peer id parsing
Nov 12, 2024
mversic
force-pushed
the
simplify_peers_in_conifg
branch
from
November 12, 2024 08:48
38af9fd
to
c1ac572
Compare
mversic
force-pushed
the
simplify_peers_in_conifg
branch
from
November 12, 2024 08:50
c1ac572
to
69b9728
Compare
mversic
force-pushed
the
simplify_peers_in_conifg
branch
2 times, most recently
from
November 12, 2024 09:22
fbe2575
to
a623cdd
Compare
s8sato
reviewed
Nov 12, 2024
mversic
force-pushed
the
simplify_peers_in_conifg
branch
from
November 12, 2024 10:15
a623cdd
to
1db7ecf
Compare
Signed-off-by: Marin Veršić <[email protected]>
mversic
force-pushed
the
simplify_peers_in_conifg
branch
from
November 12, 2024 10:48
1db7ecf
to
75136a6
Compare
s8sato
approved these changes
Nov 12, 2024
0x009922
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ed01204EE2FCD53E1730AF142D1E23951198678295047F9314B4006B0CB61850B1DB10@irohad2:1339
instead of:{ "address":"irohad2:1339", "public_key":"ed01204EE2FCD53E1730AF142D1E23951198678295047F9314B4006B0CB61850B1DB10" }
[[sumeragi.trusted_peers]]
table intotrusted_peers
array in the toml configthis is a required field so it should stand out of config subsections
Migration guide
This change will be reflected in
peer_config.toml
file.Minimal configuration before:
Minimal configuration now:
In env: