Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[suggestion] Make most of the configuration parameters optional #3501

Closed
0x009922 opened this issue May 21, 2023 · 4 comments
Closed

[suggestion] Make most of the configuration parameters optional #3501

0x009922 opened this issue May 21, 2023 · 4 comments
Labels
config-changes Changes in configuration and start up of the Iroha Enhancement New feature or request iroha2-dev The re-implementation of a BFT hyperledger in RUST

Comments

@0x009922
Copy link
Contributor

0x009922 commented May 21, 2023 •
edited
Loading

Feature request

Currently, you have to provide ALL of the configuration fields, even the maximum log level.

Instead, most of the configuration parameters should be optional and have default values.

Motivation

Simplify configuration process.
@0x009922 0x009922 added Enhancement New feature or request iroha2-dev The re-implementation of a BFT hyperledger in RUST config-changes Changes in configuration and start up of the Iroha labels May 21, 2023
@0x009922 0x009922 mentioned this issue May 23, 2023
Closed
3 tasks
@0x009922
Copy link
Contributor Author

Related:

mversic added a commit to mversic/iroha that referenced this issue May 25, 2023
@mversic
[feature] hyperledger-iroha#3501: Introduce configuration builder
5d1088b 
Signed-off-by: Marin Veršić <[email protected]>
@appetrosyan
Copy link
Contributor

#3551 Addressed this somewhat.

QA should confirm that most parameters are now optional, except for Key_Pair*, trusted_peers and *_URLs.

@0x009922 0x009922 mentioned this issue Sep 5, 2023
Closed
@0x009922
Copy link
Contributor Author

0x009922 commented Sep 5, 2023

It was probably solved by #3541, but needs verification.

@0x009922 0x009922 mentioned this issue Feb 6, 2024
Merged
@0x009922
Copy link
Contributor Author

Closed by #4239

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
config-changes Changes in configuration and start up of the Iroha Enhancement New feature or request iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@appetrosyan @0x009922