Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure npm package lock files are under version control #83

Closed
petermetz opened this issue Dec 11, 2019 · 1 comment
Closed

Ensure npm package lock files are under version control #83

petermetz opened this issue Dec 11, 2019 · 1 comment
Assignees
@petermetz
Labels
enhancement New feature or request

Comments

@petermetz
Copy link
Contributor

932f767
removed the package-lock json files because of an issue with the older version of npm that comes with NodeJS 8.

Package lock files should always be under version control, so we should work on being able to adding them back. One way to do that is to upgrade to Node 10 but that has it's own hurdles. Another solution could be to just upgrade our minimum npm version requirement but leave Node on version 8. This may not work if the newer npm is not compatible with the older node, but it's worth a try...

#29
#82
@petermetz petermetz added the enhancement New feature or request label Dec 11, 2019
@petermetz petermetz self-assigned this May 19, 2020
@petermetz
Copy link
Contributor Author

Fixed by #123

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petermetz petermetz

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@petermetz