Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: upgrade body-parser to >=1.20.3 to fix CVE-2024-45590 DoS attacks #3658

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: upgrade body-parser to >=1.20.3 to fix CVE-2024-45590 DoS attacks #3658

wants to merge 1 commit into from

Conversation

petermetz
Copy link
Contributor

Dependabot is not able to resolve this (seemingly) simple vulnerability
issue so we have to get in there and manually bump body-parser.

https://github.com/hyperledger-cacti/cacti/security/dependabot/1218

CVE ID
CVE-2024-45590

GHSA ID
GHSA-qwcr-r2fm-qrc7

Fixes #3657

Signed-off-by: Peter Somogyvari [email protected]

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

@petermetz
fix: upgrade body-parser to >=1.20.3 to fix CVE-2024-45590 DoS attacks
f75c23c 
Dependabot is not able to resolve this (seemingly) simple vulnerability
issue so we have to get in there and manually bump `body-parser`.

https://github.com/hyperledger-cacti/cacti/security/dependabot/1218

CVE ID
CVE-2024-45590

GHSA ID
GHSA-qwcr-r2fm-qrc7

Fixes hyperledger-cacti#3657

Signed-off-by: Peter Somogyvari <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@outSH outSH outSH approved these changes

@takeutak takeutak Awaiting requested review from takeutak takeutak is a code owner

@izuru0 izuru0 Awaiting requested review from izuru0 izuru0 is a code owner

@jagpreetsinghsasan jagpreetsinghsasan Awaiting requested review from jagpreetsinghsasan jagpreetsinghsasan is a code owner

@VRamakrishna VRamakrishna Awaiting requested review from VRamakrishna VRamakrishna is a code owner

@sandeepnRES sandeepnRES Awaiting requested review from sandeepnRES sandeepnRES is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix: upgrade body-parser to >=1.20.3 to fix CVE-2024-45590 DoS attacks
2 participants
@petermetz @outSH