-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reduce iterations in query
and list
by refactoring to use a transducer
pattern
#36
Closed
2 tasks done
Labels
enhancement
New feature or request
Comments
I'll also use this opportunity to beef up the test coverage on this adapter. I'm noticing now that it's not where i'd like it to be. |
TillaTheHun0
added a commit
that referenced
this issue
Mar 9, 2023
TillaTheHun0
added a commit
that referenced
this issue
Mar 9, 2023
TillaTheHun0
added a commit
that referenced
this issue
Mar 9, 2023
Nice! Great work! |
TillaTheHun0
added a commit
that referenced
this issue
Mar 11, 2023
TillaTheHun0
added a commit
that referenced
this issue
Mar 11, 2023
TillaTheHun0
changed the title
reduce iterations in
reduce iterations in Mar 13, 2023
bulk
, query
and list
by refactoring to use a transducer
patternquery
and list
by refactoring to use a transducer
pattern
|
This was referenced Mar 13, 2023
TillaTheHun0
added a commit
that referenced
this issue
Mar 13, 2023
TillaTheHun0
added a commit
that referenced
this issue
Mar 13, 2023
TillaTheHun0
added a commit
that referenced
this issue
Mar 13, 2023
TillaTheHun0
added a commit
that referenced
this issue
Mar 13, 2023
TillaTheHun0
added a commit
that referenced
this issue
Mar 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We iterate over list of documents in this adapter quite a bit, and we usually do so sequentially -- "filter out these docs", "omit this field on each doc", "add this field". Each of these actions iterates through the array, which is fine for small lists of documents but could potentially have real impacts on performance with large lists of docs.
Instead, we should leverage
transduce
to reduce the number of times we iterate through a list to a single iteration, performing all transformations during that single iteration.I should be able to refactor the code, and then run the unit tests to ensure nothing is broken
- [ ] #38The text was updated successfully, but these errors were encountered: