chore: update pinned rust version, clippy lints, remove some dead code (

#1444)

.cargo/config.toml

@@ -1,8 +1,6 @@
 [build]
 rustflags = [
     "-Zproc-macro-backtrace",
-    "-Wunused_qualifications",
-    "-Wclippy::upper_case_acronyms",
     # Flag to make build.rs scripts generate docs. Should only be used in this repository
     # internally, not by dependants.
     '--cfg=HYDROFLOW_GENERATE_DOCS',

Cargo.toml

@@ -53,3 +53,13 @@ debug-assertions = false
 
 [profile.release.package.website_playground]
 opt-level = "s"
+
+[workspace.lints.rust]
+unused_qualifications = "warn"
+
+[workspace.lints.clippy]
+allow_attributes = "warn"
+allow_attributes_without_reason = "warn"
+explicit_into_iter_loop = "warn"
+let_and_return = "allow"
+upper_case_acronyms = "warn"

benches/Cargo.toml

@@ -5,6 +5,9 @@ version = "0.0.0"
 edition = "2021"
 license = "Apache-2.0"
 
+[lints]
+workspace = true
+
 # See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html
 
 [dependencies]

benches/benches/fork_join.rs

@@ -34,7 +34,7 @@ fn benchmark_hydroflow(c: &mut Criterion) {
                 send1,
                 send2,
                 |_ctx, recv, send1, send2| {
-                    for v in recv.take_inner().into_iter() {
+                    for v in recv.take_inner() {
                         if v % 2 == 0 {
                             send1.give(Some(v));
                         } else {

benches/benches/micro_ops.rs

@@ -185,7 +185,6 @@ fn ops(c: &mut Criterion) {
                 let dist = Uniform::new(0, 100);
                 let input0: Vec<usize> = (0..NUM_INTS).map(|_| dist.sample(&mut rng)).collect();
 
-                #[allow(clippy::unnecessary_fold)]
                 {
                     hydroflow_syntax! {
                         source_iter(black_box(input0)) -> fold::<'tick>(|| 0, |accum: &mut _, elem| { *accum += elem }) -> for_each(|x| { black_box(x); });

benches/benches/reachability.rs

@@ -289,7 +289,6 @@ fn benchmark_hydroflow(c: &mut Criterion) {
     });
 }
 
-#[allow(clippy::map_clone)]
 fn benchmark_hydroflow_surface_cheating(c: &mut Criterion) {
     c.bench_function("reachability/hydroflow/surface_cheating", |b| {
         b.iter_batched(

hydro_deploy/core/Cargo.toml

@@ -7,6 +7,9 @@ license = "Apache-2.0"
 documentation = "https://docs.rs/hydro_deploy/"
 description = "Hydro Deploy"
 
+[lints]
+workspace = true
+
 [dependencies]
 anyhow = { version = "1.0.82", features = [ "backtrace" ] }
 async-process = "2.0.0"
@@ -34,3 +37,4 @@ tempfile = "3.0.0"
 tokio = { version = "1.29.0", features = [ "full" ] }
 tokio-stream = { version = "0.1.3", default-features = false }
 tokio-util = { version = "0.7.5", features = [ "compat", "io-util" ] }
+

hydro_deploy/core/src/deployment.rs

@@ -45,12 +45,12 @@ impl Deployment {
         ret
     }
 
-    #[allow(non_snake_case)]
+    #[expect(non_snake_case, reason = "constructor-esque")]
     pub fn Localhost(&self) -> Arc<LocalhostHost> {
         self.localhost_host.clone().unwrap()
     }
 
-    #[allow(non_snake_case)]
+    #[expect(non_snake_case, reason = "constructor-esque")]
     pub fn CustomService(
         &mut self,
         on: Arc<dyn Host>,
@@ -201,7 +201,6 @@ impl Deployment {
 /// Buildstructor methods.
 #[buildstructor::buildstructor]
 impl Deployment {
-    #[allow(clippy::too_many_arguments)]
     #[builder(entry = "GcpComputeEngineHost", exit = "add")]
     pub fn add_gcp_compute_engine_host(
         &mut self,
@@ -227,7 +226,6 @@ impl Deployment {
         })
     }
 
-    #[allow(clippy::too_many_arguments)]
     #[builder(entry = "AzureHost", exit = "add")]
     pub fn add_azure_host(
         &mut self,

hydro_deploy/core/src/gcp.rs

@@ -184,7 +184,10 @@ pub struct GcpComputeEngineHost {
 }
 
 impl GcpComputeEngineHost {
-    #[allow(clippy::too_many_arguments)] // TODO(mingwei)
+    #[expect(
+        clippy::too_many_arguments,
+        reason = "internal code called by builder elsewhere"
+    )]
     pub fn new(
         id: usize,
         project: impl Into<String>,

hydro_deploy/core/src/hydroflow_crate/build.rs

@@ -35,7 +35,7 @@ pub struct BuildParams {
 }
 impl BuildParams {
     /// Creates a new `BuildParams` and canonicalizes the `src` path.
-    #[allow(clippy::too_many_arguments)]
+    #[expect(clippy::too_many_arguments, reason = "internal code")]
     pub fn new(
         src: impl AsRef<Path>,
         bin: Option<String>,

hydro_deploy/core/src/hydroflow_crate/service.rs

@@ -47,7 +47,7 @@ pub struct HydroflowCrateService {
 }
 
 impl HydroflowCrateService {
-    #[allow(clippy::too_many_arguments)]
+    #[expect(clippy::too_many_arguments, reason = "internal code")]
     pub fn new(
         id: usize,
         src: PathBuf,

hydro_deploy/core/src/lib.rs

@@ -1,5 +1,3 @@
-#![allow(clippy::let_and_return)]
-
 use std::collections::HashMap;
 use std::net::SocketAddr;
 use std::sync::Arc;

hydro_deploy/core/src/ssh.rs

@@ -433,7 +433,7 @@ impl<T: LaunchedSshHost> LaunchedHost for T {
         let port = addr.port();
 
         tokio::spawn(async move {
-            #[allow(clippy::never_loop)]
+            #[expect(clippy::never_loop, reason = "tcp accept loop pattern")]
             while let Ok((mut local_stream, _)) = local_port.accept().await {
                 let mut channel = session
                     .channel_direct_tcpip(&internal_ip, port, None)

hydro_deploy/hydro_cli/Cargo.toml

@@ -7,6 +7,9 @@ license = "Apache-2.0"
 documentation = "https://docs.rs/hydro_cli/"
 description = "Hydro Deploy Command Line Interface"
 
+[lints]
+workspace = true
+
 [lib]
 name = "hydro_cli"
 # "cdylib" is necessary to produce a shared library for Python to import from.

hydro_deploy/hydro_cli/src/lib.rs

@@ -1,5 +1,8 @@
-// TODO(mingwei): For pyo3 generated code.
-#![allow(unused_qualifications, non_local_definitions)]
+#![expect(
+    unused_qualifications,
+    non_local_definitions,
+    reason = "for pyo3 generated code"
+)]
 
 use core::hydroflow_crate::ports::HydroflowSource;
 use std::cell::OnceCell;
@@ -159,7 +162,7 @@ impl Deployment {
         }
     }
 
-    #[allow(non_snake_case)]
+    #[expect(non_snake_case, reason = "pymethods")]
     fn Localhost(&self, py: Python<'_>) -> PyResult<Py<PyAny>> {
         let arc = self.underlying.blocking_read().Localhost();
 
@@ -173,7 +176,7 @@ impl Deployment {
         .into_py(py))
     }
 
-    #[allow(non_snake_case, clippy::too_many_arguments)]
+    #[expect(non_snake_case, clippy::too_many_arguments, reason = "pymethods")]
     fn GcpComputeEngineHost(
         &self,
         py: Python<'_>,
@@ -208,7 +211,7 @@ impl Deployment {
         .into_py(py))
     }
 
-    #[allow(non_snake_case, clippy::too_many_arguments)]
+    #[expect(non_snake_case, clippy::too_many_arguments, reason = "pymethods")]
     fn AzureHost(
         &self,
         py: Python<'_>,
@@ -233,7 +236,7 @@ impl Deployment {
         .into_py(py))
     }
 
-    #[allow(non_snake_case)]
+    #[expect(non_snake_case, reason = "pymethods")]
     fn CustomService(
         &self,
         py: Python<'_>,
@@ -257,7 +260,7 @@ impl Deployment {
         .into_py(py))
     }
 
-    #[allow(non_snake_case, clippy::too_many_arguments)]
+    #[expect(non_snake_case, clippy::too_many_arguments, reason = "pymethods")]
     fn HydroflowCrate(
         &self,
         py: Python<'_>,
@@ -725,7 +728,7 @@ impl ServerPort {
         pythonize(py, &self.underlying).unwrap()
     }
 
-    #[allow(clippy::wrong_self_convention)]
+    #[expect(clippy::wrong_self_convention, reason = "pymethods")]
     fn into_source<'p>(&self, py: Python<'p>) -> PyResult<&'p PyAny> {
         let realized = with_tokio_runtime(|| ServerOrBound::Server((&self.underlying).into()));
 
@@ -738,7 +741,7 @@ impl ServerPort {
         })
     }
 
-    #[allow(clippy::wrong_self_convention)]
+    #[expect(clippy::wrong_self_convention, reason = "pymethods")]
     fn into_sink<'p>(&self, py: Python<'p>) -> PyResult<&'p PyAny> {
         let realized = with_tokio_runtime(|| ServerOrBound::Server((&self.underlying).into()));
 

hydro_deploy/hydro_cli_examples/Cargo.toml

@@ -4,6 +4,9 @@ publish = false
 version = "0.0.0"
 edition = "2021"
 
+[lints]
+workspace = true
+
 [[example]]
 name = "empty_program"
 

hydro_deploy/hydroflow_deploy_integration/Cargo.toml

@@ -7,6 +7,9 @@ license = "Apache-2.0"
 documentation = "https://docs.rs/hydroflow_deploy_integration/"
 description = "`hydro_deploy` integration for Hydroflow"
 
+[lints]
+workspace = true
+
 [dependencies]
 async-recursion = "1.0.0"
 async-trait = "0.1.54"

hydro_deploy/hydroflow_deploy_integration/src/lib.rs

@@ -25,15 +25,13 @@ use tokio_util::codec::{Framed, LengthDelimitedCodec};
 pub type InitConfig = (HashMap<String, ServerBindConfig>, Option<String>);
 
 #[cfg(not(unix))]
-#[allow(dead_code)]
-type UnixStream = ();
+type UnixStream = std::convert::Infallible;
 
 #[cfg(not(unix))]
-#[allow(dead_code)]
-type UnixListener = ();
+#[expect(dead_code, reason = "conditional compilation placeholder")]
+type UnixListener = std::convert::Infallible;
 
 /// Describes how to connect to a service which is listening on some port.
-#[allow(unreachable_code)]
 #[derive(Serialize, Deserialize, Clone, Debug)]
 pub enum ServerPort {
     UnixSocket(PathBuf),

hydro_deploy/hydroflow_plus_deploy/Cargo.toml

@@ -7,6 +7,9 @@ license = "Apache-2.0"
 documentation = "https://docs.rs/hydroflow_plus_deploy/"
 description = "Library for working with hydro_deploy and hydroflow_plus"
 
+[lints]
+workspace = true
+
 [features]
 deploy = [ "hydro_deploy", "trybuild-internals-api", "toml", "prettyplease" ]
 stageleft_devel = []

hydro_deploy/hydroflow_plus_deploy/src/deploy.rs

@@ -227,7 +227,7 @@ impl<'a> Deploy<'a> for HydroDeploy {
 pub trait DeployCrateWrapper {
     fn underlying(&self) -> Arc<RwLock<HydroflowCrateService>>;
 
-    #[allow(async_fn_in_trait)]
+    #[expect(async_fn_in_trait, reason = "no auto trait bounds needed")]
     async fn create_sender(
         &self,
         port: &str,
@@ -246,12 +246,12 @@ pub trait DeployCrateWrapper {
         sender_port
     }
 
-    #[allow(async_fn_in_trait)]
+    #[expect(async_fn_in_trait, reason = "no auto trait bounds needed")]
     async fn stdout(&self) -> tokio::sync::mpsc::UnboundedReceiver<String> {
         self.underlying().read().await.stdout()
     }
 
-    #[allow(async_fn_in_trait)]
+    #[expect(async_fn_in_trait, reason = "no auto trait bounds needed")]
     async fn stderr(&self) -> tokio::sync::mpsc::UnboundedReceiver<String> {
         self.underlying().read().await.stderr()
     }

hydro_deploy/hydroflow_plus_deploy/src/lib.rs

@@ -8,7 +8,7 @@ pub(crate) mod trybuild;
 
 pub use runtime::*;
 
-#[allow(unused)]
+#[allow(clippy::allow_attributes, unused, reason = "stageleft")]
 pub(crate) mod deploy_runtime;
 
 #[cfg(feature = "deploy")]

hydroflow/Cargo.toml

@@ -7,6 +7,9 @@ license = "Apache-2.0"
 documentation = "https://docs.rs/hydroflow/"
 description = "Hydro's low-level dataflow runtime and IR"
 
+[lints]
+workspace = true
+
 [features]
 default = [ "macros", "nightly", "debugging" ]
 

hydroflow/examples/deadlock_detector/peer.rs

@@ -20,7 +20,7 @@ pub(crate) async fn run_detector(opts: Opts, peer_list: Vec<String>) {
     let reader = tokio::io::BufReader::new(tokio::io::stdin());
     let stdin_lines = LinesStream::new(reader.lines());
 
-    #[allow(clippy::map_identity)]
+    #[expect(clippy::map_identity, reason = "helps type inference?")]
     let mut hf: Hydroflow = hydroflow_syntax! {
         // fetch peers from file, convert ip:port to a SocketAddr, and tee
         peers = source_iter(peer_list)

hydroflow/examples/example_syntax_empty.rs

@@ -1,4 +1,4 @@
-#![allow(unused_mut, unused_variables)]
+#![expect(unused_mut, unused_variables, reason = "example code")]
 
 use hydroflow::hydroflow_syntax;
 

hydroflow/examples/kvs_bench/protocol/mod.rs

@@ -38,7 +38,7 @@ pub enum KvsResponse<const SIZE: usize> {
     _PutResponse {
         key: u64,
     },
-    #[allow(dead_code)]
+    #[expect(dead_code, reason = "benchmark discards responses")]
     GetResponse {
         key: u64,
         reg: MyLastWriteWins<SIZE>,

hydroflow/examples/three_clique/main.rs

@@ -18,7 +18,7 @@ pub fn main() {
     // An edge in the input data = a pair of `usize` vertex IDs.
     let (edges_send, edges_recv) = hydroflow::util::unbounded_channel::<(usize, usize)>();
 
-    #[allow(clippy::map_identity)]
+    #[expect(clippy::map_identity, reason = "code symmetry")]
     let mut df = hydroflow_syntax! {
         edges = source_stream(edges_recv) -> tee();
 

hydroflow/src/compiled/pull/cross_join.rs

@@ -61,7 +61,7 @@ where
                 self.state.draw_from_left = !self.state.draw_from_left;
 
                 // try to fetch from the specified side
-                #[allow(clippy::collapsible_else_if)]
+                #[expect(clippy::collapsible_else_if, reason = "code symmetry")]
                 if self.state.draw_from_left {
                     if let Some(l) = self.lhs.next() {
                         self.state.draw_from_left = true;

hydroflow/src/compiled/pull/mod.rs

@@ -1,5 +1,5 @@
 //! Pull-based operator helpers, i.e. [`Iterator`] helpers.
-#![allow(missing_docs)] // TODO(mingwei)
+#![allow(missing_docs, reason = "// TODO(mingwei)")]
 
 mod cross_join;
 pub use cross_join::*;

hydroflow/src/lib.rs

@@ -1,8 +1,4 @@
 #![cfg_attr(feature = "nightly", feature(never_type))]
-#![allow(type_alias_bounds)]
-#![allow(clippy::let_and_return)]
-#![allow(clippy::iter_with_drain)]
-#![allow(clippy::explicit_auto_deref)]
 #![warn(missing_docs)]
 
 //! Hydroflow is a low-level dataflow-based runtime system for the [Hydro Project](https://hydro.run/).
@@ -22,7 +18,6 @@
 //! For more examples, check out the [`examples` folder on Github](https://github.com/hydro-project/hydroflow/tree/main/hydroflow/examples).
 
 pub mod compiled;
-pub mod props;
 pub mod scheduled;
 pub mod util;