Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EyeDropper doesn't grab the color in firefox #44

Open
madisonc33 opened this issue May 18, 2023 · 11 comments
Open

EyeDropper doesn't grab the color in firefox #44

madisonc33 opened this issue May 18, 2023 · 11 comments
Assignees
Labels
bug Something isn't working

Comments

@madisonc33
Copy link

In firefox, the eyedropper doesn't appear to actually select the color. Seeing https://gradient-package-demo.web.app/ and in own use case

@hxf31891
Copy link
Owner

@madisonc33 Firefox (and Safari) have always been an issue for the eyedropper, the browsers aren't compatible with window.eyedropper. I'll take a look.

@hxf31891
Copy link
Owner

@madisonc33 I just tested on Firefox 106.0.3, it seems to be working fine. Can you please attach a video of the behavior your getting.

@madisonc33
Copy link
Author

I'm not getting the color even when trying https://gradient-package-demo.web.app/ in firefox but let me update and test a little more to get you more info. Uncaught TypeError: pickerCanvas.getImageData is not a function and Uncaught (in promise) Invalid element provided as first argument are errors I'm seeing

@madisonc33
Copy link
Author

@hxf31891 here is a sandbox where when running firefix I am seeing the same issue - color picker sandbox

if you try to get the color from one of the above boxes, it's not actually updating

Running the same sandbox in chrome works, but not in firefox

@hxf31891
Copy link
Owner

hxf31891 commented Jun 7, 2023

@madisonc33 looking into this now, thank you for posting the sandbox.

@hxf31891
Copy link
Owner

hxf31891 commented Jun 7, 2023

@madisonc33 unfortunately I still can reproduce. See screen recoding here. Lets get a little more info flowing here. Whats your Firefox version and what are you running on? PC or Mac?

@madisonc33
Copy link
Author

@hxf31891 I'm using Firefox 114.0 (64-bit) on a mac

@hxf31891
Copy link
Owner

hxf31891 commented Jun 8, 2023

@madisonc33 I'm perplexed. I am also running 114 on Mac. Are you silicon or Intel? Do you have any security tighter settings on that browser?

@madisonc33
Copy link
Author

@hxf31891 Silicon - just the standard settings are far as I'm aware of

@madisonc33
Copy link
Author

I just tried it on a different computer with intel and it worked when selecting the colors at the top (but not the black font or off the slider) running 114.0.2

@hxf31891
Copy link
Owner

@madisonc33 thanks for keeping up with this, I have been praying that the EyeDropper API would be gaining traction with non chromium browsers but it looks like I am not going to get lucky there. I may need to rethink how this works.

@hxf31891 hxf31891 self-assigned this Nov 28, 2023
@hxf31891 hxf31891 added the bug Something isn't working label Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants