Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

android: fails to build #128

Closed
phlip9 opened this issue May 22, 2023 · 0 comments · Fixed by #129
Closed

android: fails to build #128

phlip9 opened this issue May 22, 2023 · 0 comments · Fixed by #129

Comments

@phlip9
Copy link
Contributor

phlip9 commented May 22, 2023

Related PR: #125

Description

Building on Android fails:

$ cargo check --target=aarch64-linux-android
    Checking keyring v2.0.2
error[E0433]: failed to resolve: use of undeclared crate or module `default`
   --> src/lib.rs:176:54
    |
176 |         static ref DEFAULT: Box<CredentialBuilder> = default::default_credential_builder();
    |                                                      ^^^^^^^
    |                                                      |
    |                                                      use of undeclared crate or module `default`
    |                                                      help: a struct with a similar name exists: `DEFAULT`

error: could not compile `keyring` (lib) due to previous error

This is because there is no default keyring backend for the platform, even though a user could provide their own backend.

brotskydotcom added a commit to brotskydotcom/keyring-rs that referenced this issue May 25, 2023
This integrates the fix from @phlip9 but reorganizes it slightly to keep all the keystores together.

Fixes hwchen#128.
brotskydotcom added a commit that referenced this issue May 25, 2023
This release integrates two improvements from @phlip9:

- We don't do an unnecessary allocation on every get_password call.
- There is always a default store available on all platforms (including Android - fixes android: fails to build #128).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant