-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make DioCacheManager._buildResponse() non-private #85
Comments
Thanks for your commit, I will review this change on a non-working day, please be patient. |
@slavap After reviewing your change, I found that we need to upgrade to Dio 4 to support these, so the feature for support flutter 2.0 and null-safety maybe need to be advanced in advance. |
@franticn yes, that’s what I said in the opening description, Dio 4 and null safety PR must be accepted first. |
@franticn Please add this change, needed PR in already merged. |
@hurshi
After accepting #84
Please add the following minor changes:
Make DioCacheManager._buildResponse() non-private and async (make it protected), with changed to RequestInterceptorHandler it is currently too hard to adjust cached data additionally in DioCacheManager descendants.
And add await in two places of DioCacheManager where buildResponse() called.
It is proper change for new handler based structure. Example: there are some data in cache and they are still valid, but some headers and cookies are changed, so I need just slightly adjust Response without discarding the cache. So I have descendant which manages this after data returned from the cache.
The text was updated successfully, but these errors were encountered: