Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make logging @trusted/@safe/pure (?) #78

Open
Cogitri opened this issue Dec 2, 2019 · 3 comments
Open

Make logging @trusted/@safe/pure (?) #78

Cogitri opened this issue Dec 2, 2019 · 3 comments

Comments

@Cogitri
Copy link
Contributor

Cogitri commented Dec 2, 2019

No description provided.

@Cogitri Cogitri changed the title Make logging @trusted/@safe Make logging @trusted/@safe/pure (?) Dec 2, 2019
@Heromyth
Copy link
Contributor

Heromyth commented Dec 5, 2019

These attributes are not always useful. They bring more troubles than gains before they are implemented by D compiler. The @nogc may be useful. In fact, we have implemented a simple logger which supports betterC. It is included in another project which has not be published.

@Cogitri
Copy link
Contributor Author

Cogitri commented Dec 5, 2019

These attributes are not always useful. They bring more troubles than gains before they are implemented by D compiler.

Hm, but others (including me) might find them useful to isolate bugs and not being able to call the log functions in them is unfortunate

@Heromyth
Copy link
Contributor

Heromyth commented Dec 5, 2019

It's better for the underlying APIs to be marked as @trusted/@safe/pure if they are tested well. As for the logger's APIs, we have no any reason to refuse a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Heromyth @Cogitri