Groove shuffle implementation #277
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you wanna complete the implementation of the groove command I'll merge it :) |
eethann
changed the title
|
Updated to use a Didn't test with animated clocks yet. Used globals for worker process state. |
|
I think this should be good to merge at this point. |
|
One possible enhancement would be jitter correction on the clock: check actual time against scheduled time each tick and compensate. Not essential though. |
|
What ever happened with this? Any bugs? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first implementation of groove in Orca. It doesn't handle restarts gracefully (wherever you restart will become a downbeat relative to the groove), and the clock needs to be restarted when groove is changed. Basic functionality seems to work though:
groove:X;Y;Zsets ratios between ticks,groove:Xgives the standard MPC style shuffle,groove:50is the default, linear clock.