Skip to content
This repository has been archived by the owner on Dec 6, 2024. It is now read-only.

Merge attempt into django-oauth-toolkit #23

Open
TM2500 opened this issue Jan 20, 2020 · 9 comments
Open

Merge attempt into django-oauth-toolkit #23

TM2500 opened this issue Jan 20, 2020 · 9 comments

Comments

@TM2500
Copy link
Contributor

TM2500 commented Jan 20, 2020

Hi there,

since there are a still some guys who wish that JWT be implemented in the django-oauth-toolkit and this repo is one of the few sane modules to successfully implemented it as a separate module I would like to make an attempt to merge it into the DOT-lib directly.

The first thing I would do, would be resolving issue #12 and make a PR into this repo and then I would refactor the module to integrate it nicely into DOT.

@TM2500 TM2500 changed the title Merg attempt into django-oauth-toolkit Merge attempt into django-oauth-toolkit Jan 20, 2020
@rafa-munoz
Copy link

Excellent. Your help will be highly valuable to everyone :)

@TM2500
Copy link
Contributor Author

TM2500 commented Jan 20, 2020

I'll let you and your team know as soon as I can show progress.
But please keep in mind that, although I'm able to do some stuff for this at work, I have to do the heavy-lifting in my free time.
So please be patient. I think a reasonable timeframe for #12 would be in a couple of weeks~.

@rafa-munoz
Copy link

No worries, I think that having by now this solution that just works, nobody is in a hurry. Thank you.

@TM2500
Copy link
Contributor Author

TM2500 commented Jan 23, 2020

Since Python2 and Django1.11 is near it's EOL I'm gonna drop support for both of them when #12 is closed.

dot already dropped both of them!

I don't think that there is much pyhon2-specific stuff there, but I will take al closer look at it when #12 is closed.

TM2500 added a commit to TM2500/django-oauth-toolkit-jwt that referenced this issue Feb 7, 2020
@TM2500
Copy link
Contributor Author

TM2500 commented Feb 13, 2020

Since #24 is thankfully accepted, I'm going to start to work on this.

@TM2500
Copy link
Contributor Author

TM2500 commented Mar 27, 2020

Since #26 is merged, I think most of the work is done on updating this library.

With your permission my next step would be the contact the jazzband, what have to be done in order to include most of this library in theirs. I keep you posted on any progress.

@rafa-munoz
Copy link

Great job, thanks!

@n2ygk
Copy link

n2ygk commented Jul 1, 2021

Since #26 is merged, I think most of the work is done on updating this library.

With your permission my next step would be the contact the jazzband, what have to be done in order to include most of this library in theirs. I keep you posted on any progress.

@TM2500 Have you submitted a PR to django-oauth-toolkit? I don't think you need to join jazzband -- but of course it would be great if you did. Anyone can submit PRs. I suspect I know someone who would be interested in merging this ;-)

@TM2500
Copy link
Contributor Author

TM2500 commented Jul 1, 2021

@n2ygk I'm sorry to say, that my project, I depended on this library, evolved to a state, where Django was not the best fit anymore. So my intend to merge or get in touch with jazzband was and is no longer a high priority on my agenda.

I propably should have closed that issue or mark it in another way as stale, Sorry for that -_-

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants