Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

/repos/<repo_key>/commit/<sha>.{patch,diff} "API" #56

Open
cvrebert opened this issue Dec 13, 2013 · 3 comments
Open

/repos/<repo_key>/commit/<sha>.{patch,diff} "API" #56

cvrebert opened this issue Dec 13, 2013 · 3 comments
Labels
enhancement

Comments

@cvrebert
Copy link
Contributor

https://github.com/blog/967-github-secrets
https://github.com/dmak/cdk/commit/9b0478d50c7b5ca10f77fb01d89329db5fe80625.diff
https://github.com/dmak/cdk/commit/9b0478d50c7b5ca10f77fb01d89329db5fe80625.patch
rajivm added a commit that referenced this issue Dec 13, 2013
@rajivm
add support for retrieving .diff (#56)
421dd8c
@rajivm
Copy link
Contributor

rajivm commented Dec 13, 2013

Actually using /commits/ instead of /commit/ ... Yes, this is different than the above, but the above is also not part of the API url set anyways, and this is more parallel with /compare/ (which also supports .{patch,diff})

@cvrebert
Copy link
Contributor Author

I think it's better to stick with /commit/ for the diff "API". There turn out to be gnarly routing issues with trying to make them both share /commits/.

cvrebert added a commit that referenced this issue Dec 17, 2013
@cvrebert
sort out Repo API for individual commits & their diffs
765f8ac 
X-Ref: #56
@cvrebert cvrebert mentioned this issue Dec 17, 2013
Closed
cvrebert added a commit that referenced this issue Dec 17, 2013
@cvrebert
sort out Repo API for individual commits & their diffs
6bf6674 
X-Ref: #56
cvrebert added a commit that referenced this issue Dec 17, 2013
@cvrebert
sort out Repo API for individual commits & their diffs
75c55da 
X-Ref: #56
@cvrebert
Copy link
Contributor Author

Interesting note regarding .patch output: http://stackoverflow.com/questions/15790120/what-is-the-first-line-of-git-format-patch-output

rajivm added a commit that referenced this issue Dec 17, 2013
@rajivm @cvrebert
add support for retrieving .diff (#56)
08afe0d
rajivm added a commit that referenced this issue Dec 17, 2013
@rajivm @cvrebert
add support for retrieving .diff (#56)
471c089
rajivm added a commit that referenced this issue Dec 17, 2013
@rajivm @cvrebert
add support for retrieving .diff (#56)
36894b9
rajivm added a commit that referenced this issue Dec 17, 2013
@rajivm @cvrebert
add support for retrieving .diff (#56)
c82c99c
rajivm added a commit that referenced this issue Dec 17, 2013
@rajivm @cvrebert
add support for retrieving .diff (#56)
e7a05e5
rajivm added a commit that referenced this issue Dec 17, 2013
@rajivm @cvrebert
add support for retrieving .diff (#56)
93784c5
rajivm added a commit that referenced this issue Dec 17, 2013
@rajivm @cvrebert
add support for retrieving .diff (#56)
1e3a2e1
rajivm added a commit that referenced this issue Dec 17, 2013
@rajivm @cvrebert
add support for retrieving .diff (#56)
74128ea
rajivm added a commit that referenced this issue Dec 20, 2013
@rajivm @cvrebert
add support for retrieving .diff (#56)
12fa071
cvrebert added a commit that referenced this issue Dec 20, 2013
@cvrebert
add tests for .diff endpoint (#56)
7da1a61
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rajivm @cvrebert