Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LST axis is incorrect in the waterfall plot when there is a discontinuity in time #5

Open
hughbg opened this issue Mar 19, 2018 · 2 comments

Comments

@hughbg
Copy link
Owner

hughbg commented Mar 19, 2018

Discontinuities in spectrometer data over time can be caused by restarting the spectrometer or correlator. A single h5 file may contain a gap in time. If it does, then the waterfall plot must indicate this using the y-axis. Currently the assumption is that there is a continuous range of LSTs from the first one to the last one, which means the y-axis is incorrect in the case of a discontinuity..

@hughbg
Copy link
Owner Author

hughbg commented Jun 4, 2018

There is a way to deal with this - add the missing LSTs, filling them with 0s, and masking them. This would be for display purposes in plot_waterfall, and in plot_ds9 these could be put in the FITs file.

@jaycedowell
Copy link
Collaborator

Most of the time when I have seen a discontinuity it is from the day rolling over (23:56:04 -> 0:00:00) rather then from gaps in the data. What about "unrolling" the LSTs before sorting and then protecting any function that takes in an LST with a modulo one day?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants