From a308d28d397af77c6a6b6d3b397991b555677007 Mon Sep 17 00:00:00 2001
From: Yih-Dar <2521628+ydshieh@users.noreply.github.com>
Date: Thu, 24 Oct 2024 19:07:23 +0200
Subject: [PATCH] [auto. ping] Avoid sending empty info + add more team members
 (#34383)

* update

* update

---------

Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
---
 .github/workflows/check_failed_model_tests.yml |  2 +-
 utils/check_bad_commit.py                      | 10 +++++++++-
 utils/process_bad_commit_report.py             | 13 ++++++++++++-
 3 files changed, 22 insertions(+), 3 deletions(-)

diff --git a/.github/workflows/check_failed_model_tests.yml b/.github/workflows/check_failed_model_tests.yml
index f229765994d585..f3ea8646900ad2 100644
--- a/.github/workflows/check_failed_model_tests.yml
+++ b/.github/workflows/check_failed_model_tests.yml
@@ -106,7 +106,7 @@ jobs:
           } >> "$GITHUB_ENV"
 
       - name: Send processed report
-        if: ${{ env.REPORT_TEXT != '' }}
+        if: ${{ !endsWith(env.REPORT_TEXT, '{}') }}
         uses: slackapi/slack-github-action@6c661ce58804a1a20f6dc5fbee7f0381b469e001
         with:
           # Slack channel id, channel name, or user id to post message.
diff --git a/utils/check_bad_commit.py b/utils/check_bad_commit.py
index 091ed5c4a427f9..adb25f11264b12 100644
--- a/utils/check_bad_commit.py
+++ b/utils/check_bad_commit.py
@@ -182,7 +182,15 @@ def get_commit_info(commit):
                 info = {"test": test, "commit": commit}
                 info.update(get_commit_info(commit))
                 failed_tests_with_bad_commits.append(info)
-            reports[model]["single-gpu"] = failed_tests_with_bad_commits
+
+            # If no single-gpu test failures, remove the key
+            if len(failed_tests_with_bad_commits) > 0:
+                reports[model]["single-gpu"] = failed_tests_with_bad_commits
+            else:
+                reports[model].pop("single-gpu", None)
+
+        # remove the models without any test failure
+        reports = {k: v for k, v in reports.items() if len(v) > 0}
 
         with open(args.output_file, "w", encoding="UTF-8") as fp:
             json.dump(reports, fp, ensure_ascii=False, indent=4)
diff --git a/utils/process_bad_commit_report.py b/utils/process_bad_commit_report.py
index f61f1b106644aa..513dc8df3a3b3c 100644
--- a/utils/process_bad_commit_report.py
+++ b/utils/process_bad_commit_report.py
@@ -28,7 +28,18 @@
         data = json.load(fp)
 
     # TODO: extend
-    team_members = ["ydshieh", "zucchini-nlp", "ArthurZucker", "gante", "LysandreJik", "molbap", "qubvel"]
+    team_members = [
+        "ydshieh",
+        "zucchini-nlp",
+        "ArthurZucker",
+        "gante",
+        "LysandreJik",
+        "molbap",
+        "qubvel",
+        "Rocketknight1",
+        "muellerzr",
+        "SunMarc",
+    ]
 
     # Counting the number of failures grouped by authors
     new_data = {}