Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No Acoustic Echo Cancellation #151

Open
Galaxywalk opened this issue Dec 19, 2024 · 2 comments
Open

No Acoustic Echo Cancellation #151

Galaxywalk opened this issue Dec 19, 2024 · 2 comments

Comments

@Galaxywalk
Copy link

It seems that the current pipeline is almost linear and no acoustic echo cancellation is implemented. It means that when the speaker speaks the responses from LLM, the microphone may record this audio incorrectly?

@eustlb
Copy link
Collaborator

eustlb commented Dec 19, 2024

Hey @Galaxywalk,
The pipeline is implemented such that as soon as an end of speech is detected by the VAD, it stops listening to the microphone until the spoken LLM answer has been fully played.
Echo cancellation is the one big feature we would love to implement because it would enable interruptions.

@Galaxywalk
Copy link
Author

Galaxywalk commented Dec 19, 2024

I'm currently working on acoustic echo cancellation for a language-instructed robot, which I believe is crucial. Could you share your schedule for this feature? Also, packaging the current pipeline into a ROS package would significantly enhance its usability and maintainability for ROS users. Do you have any plans for this?

I've already made some progress in this area and would be eager to contribute. What are your thoughts on external contributions, and would it be possible for an external PR about it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants