-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorder bindings #141
Comments
Hello ! I want to thank you first for this amazing project and I would love to contribute! I have been looking for this kind of library for a while to write a GPU-powered wasm semantic search module (docvec ) . As I understand it, to ensure the best performance across the board, you would prefer to have |
Hi @AmineDiro, This issue was quickly written in response to reading the following: https://toji.dev/webgpu-best-practices/bind-groups#grouping-resources-based-on-frequency-of-change As I understand it, we want to group resources based on frequency of change. I'm unsure if it will have a meaningful impact on performance, more reading needs to be done. I try and open these issues when ideas arise, it may not be a fruitful avenue. Join the discord if you want to contribute/discuss more: https://discord.gg/XFe33KQTG4 |
Thanks for the prompt response! I'll take a look a look at this and jump on the discord 👍🏼 |
Our kernel preamble currently looks like the following, seems fine right? WRONG!
In reality, you want your bindings ordered in ascending order of change.
What does that mean?
Your
read_write
bindgroup should be@group(0) @binding(0)
, because every operation has a single output.Simple, but boring change to make throughout the codebase.
The text was updated successfully, but these errors were encountered: