Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken image link in the quickstart document #2374

Closed
ariG23498 opened this issue Dec 23, 2024 · 7 comments · Fixed by #2381
Closed

Broken image link in the quickstart document #2374

ariG23498 opened this issue Dec 23, 2024 · 7 comments · Fixed by #2381

Comments

@ariG23498
Copy link
Contributor

>>> url = 'https://datasets-server.huggingface.co/assets/imagenet-1k/--/default/test/12/image/image.jpg'

This is a broken link. I can create a PR to replace this with another image so that the image below does not break too.

@rwightman
Copy link
Collaborator

@ariG23498 sure, PR would be great. Should probably be another image on a HF server to avoid any upset people :) Not 100% what example images are used in transformers docs .. I know there is a beignet one but not sure it's best for ImageNet-1k classifiers, heh..

@ariG23498
Copy link
Contributor Author

I was thinking the same. I have seen this image to be widely used in the transformers docs. Would you like for me to use this?

image of two cats sleeping

Note: This image is hosted in the cocodataset. We could upload the image to a folder inside the hf docs dataset named timm. I can take care of this as well. WDYT?

@rwightman
Copy link
Collaborator

@ariG23498 that'd be perfect

@ariG23498
Copy link
Contributor Author

@rwightman could you approve and merge this PR?

That would un-block me into adding the image to the docs. TIA!

@rwightman
Copy link
Collaborator

@ariG23498 hmm, it's asking me to do a full sign on with Kolide to access that repo. I'm away from my normal machine over holidays so can only access the open source stuff I'm working on :/

@ariG23498
Copy link
Contributor Author

@rwightman I have merged the PR in HF, and have also started #2381 in timm.

@rwightman
Copy link
Collaborator

@ariG23498 thanks! merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants