-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request][Community] Ability to pass text_embeddings/uncond_embeddings as arguments in pipe call #955
Comments
Hey @hadaev8, Do you think we could use a community pipeline for this? |
Also see: #958 -> in general ok for me this request - curious to hear other opinions though! |
Since aesthetic gradients modify text encoder output it works with every pipe. Didnt tested with new inpainting, but why not. Also, if it is acceptable in this repo, i would like to contribute example notebook or something showing how it work with all default pipes. |
@hadaev8 |
Hey @hadaev8 ! Could you point us to an example of aesthetic gradients ? Hearing it for the first time :) If it's a really big use case I would also be in favor of it. For now I see two things which could benifit from this
so unless we have a really big use case, I would like to keep the pipelines simple :) |
I've seen the results of it, definitely worth taking a look. The end results are amazing |
@patil-suraj Basically it change weights of text encoder to match clip image representations. Almost all possible to do outside of pipe, but because of such tuning catastrophic forgetting kicks in, so i think (and author do it too) its better to pass unchanged uncond embeddings from original text model. In my notebooks i just copypasted whole pipe function for very minor change. |
Awesome, thanks @hadaev8 ! |
This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Please note that issues that do not follow the contributing guidelines are likely to be ignored. |
This still would be nice to have |
Actually fine for to add this ! Would someone be interested in opening a PR for this? I won't find time anytime soon, but I'll keep this issue on my radar in case more people ask for it |
@patrickvonplaten |
Mostly solved by #2071 |
Is your feature request related to a problem? Please describe.
Im experimenting with aesthetic gradients and need to overwrite pip call to pass text_embeddings/uncond_embeddings.
Also it might save a bit of time with making a lot of images with same promt.
Describe the solution you'd like
Ability to pass text_embeddings/uncond_embeddings to pipe call.
Describe alternatives you've considered
Idk. Maybe split everything to separate functions and make it less cluttered.
The text was updated successfully, but these errors were encountered: