-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pytest doesn't run on python3.12 #7441
Comments
Does it build on any other distro? What's the error message? |
Sorry, i was to quick to parse the error log and jumped to conclusion. It seems to happen while running pytest, not while installing the package, but the linked PEP is still relevant. https://cache.nixos.org/log/8kgw3gqpd3r9d48gb1xibz592226xhys-python3.12-diffusers-0.27.1.drv likely relevant bit:
|
Does it happen in Linux? |
yes |
How are you installing the package? |
We're packaging diffusers on linux/nixpkgs for python 3.12, which involves running the test suite to make sure it works correctly. Here is our build recipe but it is likely of low interest to you. The reason it fails is due to the use of I updated the title, since most python 3.12 users should be able to fetch the prebuilt wheels from pypi and install it just fine. I'm sorry for not being able to provide an simple debuggable reproduction for you, my FHS (non-nixos) machines are currently out of commission, and my docker setup is being grumpy. |
Thanks for providing this information. I think this warrants a discussion with the broader Python community no? Probably better off in PyTest? |
The fault is not with pytest as it does not feature a single import of |
You are talking to one of the maintainers :-) You mentioned:
This tells me we need to handle the corresponding distutils import based on the Python version. I will look into it. |
This thread is useful in this regard: https://stackoverflow.com/questions/69858963/how-can-one-fully-replace-distutils-which-is-deprecated-in-3-10. @yiyixuxu we should try to replace |
It fixes the But now the tests fail with "RuntimeError: Dynamo is not supported on Python 3.12+".
But i assume that issue is upstream? |
Yes, that is a PyTorch problem it seems and is better filed in the PyTorch repository. I will add a decorator to those tests to skip for Python 3.12. |
Describe the bug
https://peps.python.org/pep-0632/
Reproduction
./setup.py
Logs
No response
System Info
diffusers 0.27.1, python 3.12, nixos 23.11
Who can help?
@DN6 @sayakpaul @yiyixuxu
The text was updated successfully, but these errors were encountered: