Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DDPMScheduler claims to have set_alpha_to_one in combination with steps_offset #6926

Open
bghira opened this issue Feb 9, 2024 · 6 comments
Labels
scheduler stale Issues that haven't received updates

Comments

@bghira
Copy link
Contributor

bghira commented Feb 9, 2024

When inspecting the configuration for SD/SDXL we noticed that set_alpha_to_one is mentioned in the scheduler's init docstring but it is nowhere to be found. It seems that DDPM either lacks this functionality, or does not need it.

@yiyixuxu
Copy link
Collaborator

Hi @bghira

It wasn't implemented for DDPM so I think it's a mistake in docstring.

Do you think we need to add this?

@bghira
Copy link
Contributor Author

bghira commented Feb 10, 2024

i'm not sure that it needs it, there is a further discussion on this issue now in #6068

@sayakpaul
Copy link
Member

#6931

Copy link

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@github-actions github-actions bot added the stale Issues that haven't received updates label Mar 13, 2024
@sayakpaul
Copy link
Member

#7128

@github-actions github-actions bot removed the stale Issues that haven't received updates label Mar 14, 2024
Copy link

github-actions bot commented Apr 7, 2024

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@github-actions github-actions bot added the stale Issues that haven't received updates label Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scheduler stale Issues that haven't received updates
Projects
None yet
Development

No branches or pull requests

3 participants