Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise error for incorrect JSON serialization #7273

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Raise error for incorrect JSON serialization #7273

merged 1 commit into from
Nov 18, 2024
+5 −0

Conversation

varadhbhatnagar
Copy link
Contributor

Raise error when lines = False and batch_size < Dataset.num_rows in Dataset.to_json().

Issue: #7037

Related PRs:
#7039 #7181

@varadhbhatnagar
Copy link
Contributor Author

PTAL @lhoestq @albertvillanova

@varadhbhatnagar varadhbhatnagar mentioned this pull request Nov 1, 2024
Closed
@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

lhoestq
lhoestq approved these changes Nov 18, 2024
View reviewed changes
Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks !

@lhoestq lhoestq merged commit 2049c00 into huggingface:main Nov 18, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhoestq lhoestq lhoestq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@varadhbhatnagar @HuggingFaceDocBuilderDev @lhoestq