Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion to add shape info in preprocessing #99

Open
mishig25 opened this issue Jul 17, 2023 · 2 comments
Open

Suggestion to add shape info in preprocessing #99

mishig25 opened this issue Jul 17, 2023 · 2 comments

Comments

@mishig25
Copy link
Collaborator

In the section about preprocessing, it would be useful to add type/shape information of data produced after pre processing the data.

Specifically,

input_features = example["input_features"]
here it be very useful to add as a comment what is the type/shape of input_features. Is it 3d array of floats like [time, freq, ampl] ?

@snehilsanyal
Copy link

+1 to this.
Either a comment or a cell with an output that shows the entries and type/shape of input_features, I encountered this and tried to incorporate a cell for better visualization in my notebooks.
I also think, that if this is introduced in initial lessons, it would be of great help and relevance for the next lessons.
I found a very useful link in the transformer docs on data preprocessing here which mentions how padding and truncation can vary the shape of input_features to make every audio sample of the same size. See the image below:

image

@mishig25
Copy link
Collaborator Author

cc: @sanchit-gandhi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants