From 76251a4d979ea7457d3e42bcf77b624d3b98a5d4 Mon Sep 17 00:00:00 2001 From: Alvaro Bartolome <36760800+alvarobartt@users.noreply.github.com> Date: Mon, 7 Oct 2024 14:24:54 +0200 Subject: [PATCH] Revert `ingressClassName` over `annotation` (#108) More information at https://cloud.google.com/kubernetes-engine/docs/concepts/ingress --- examples/gke/tei-deployment/cpu-config/ingress.yaml | 4 +++- examples/gke/tei-deployment/gpu-config/ingress.yaml | 4 +++- examples/gke/tei-from-gcs-deployment/cpu-config/ingress.yaml | 4 +++- examples/gke/tei-from-gcs-deployment/gpu-config/ingress.yaml | 4 +++- examples/gke/tgi-deployment/config/ingress.yaml | 4 +++- examples/gke/tgi-from-gcs-deployment/config/ingress.yaml | 4 +++- 6 files changed, 18 insertions(+), 6 deletions(-) diff --git a/examples/gke/tei-deployment/cpu-config/ingress.yaml b/examples/gke/tei-deployment/cpu-config/ingress.yaml index f46f916f..286eba14 100644 --- a/examples/gke/tei-deployment/cpu-config/ingress.yaml +++ b/examples/gke/tei-deployment/cpu-config/ingress.yaml @@ -2,8 +2,10 @@ apiVersion: networking.k8s.io/v1 kind: Ingress metadata: name: tei-ingress + # https://cloud.google.com/kubernetes-engine/docs/concepts/ingress + annotations: + kubernetes.io/ingress.class: "gce" spec: - ingressClassName: "gce" rules: - http: paths: diff --git a/examples/gke/tei-deployment/gpu-config/ingress.yaml b/examples/gke/tei-deployment/gpu-config/ingress.yaml index f46f916f..286eba14 100644 --- a/examples/gke/tei-deployment/gpu-config/ingress.yaml +++ b/examples/gke/tei-deployment/gpu-config/ingress.yaml @@ -2,8 +2,10 @@ apiVersion: networking.k8s.io/v1 kind: Ingress metadata: name: tei-ingress + # https://cloud.google.com/kubernetes-engine/docs/concepts/ingress + annotations: + kubernetes.io/ingress.class: "gce" spec: - ingressClassName: "gce" rules: - http: paths: diff --git a/examples/gke/tei-from-gcs-deployment/cpu-config/ingress.yaml b/examples/gke/tei-from-gcs-deployment/cpu-config/ingress.yaml index 34e64170..b6855a51 100644 --- a/examples/gke/tei-from-gcs-deployment/cpu-config/ingress.yaml +++ b/examples/gke/tei-from-gcs-deployment/cpu-config/ingress.yaml @@ -3,8 +3,10 @@ kind: Ingress metadata: name: tei-ingress namespace: hf-gke-namespace + # https://cloud.google.com/kubernetes-engine/docs/concepts/ingress + annotations: + kubernetes.io/ingress.class: "gce" spec: - ingressClassName: "gce" rules: - http: paths: diff --git a/examples/gke/tei-from-gcs-deployment/gpu-config/ingress.yaml b/examples/gke/tei-from-gcs-deployment/gpu-config/ingress.yaml index 34e64170..b6855a51 100644 --- a/examples/gke/tei-from-gcs-deployment/gpu-config/ingress.yaml +++ b/examples/gke/tei-from-gcs-deployment/gpu-config/ingress.yaml @@ -3,8 +3,10 @@ kind: Ingress metadata: name: tei-ingress namespace: hf-gke-namespace + # https://cloud.google.com/kubernetes-engine/docs/concepts/ingress + annotations: + kubernetes.io/ingress.class: "gce" spec: - ingressClassName: "gce" rules: - http: paths: diff --git a/examples/gke/tgi-deployment/config/ingress.yaml b/examples/gke/tgi-deployment/config/ingress.yaml index 11cb1a20..a5c5fc1d 100644 --- a/examples/gke/tgi-deployment/config/ingress.yaml +++ b/examples/gke/tgi-deployment/config/ingress.yaml @@ -2,8 +2,10 @@ apiVersion: networking.k8s.io/v1 kind: Ingress metadata: name: tgi-ingress + # https://cloud.google.com/kubernetes-engine/docs/concepts/ingress + annotations: + kubernetes.io/ingress.class: "gce" spec: - ingressClassName: "gce" rules: - http: paths: diff --git a/examples/gke/tgi-from-gcs-deployment/config/ingress.yaml b/examples/gke/tgi-from-gcs-deployment/config/ingress.yaml index f8710e17..f7db6bc4 100644 --- a/examples/gke/tgi-from-gcs-deployment/config/ingress.yaml +++ b/examples/gke/tgi-from-gcs-deployment/config/ingress.yaml @@ -3,8 +3,10 @@ kind: Ingress metadata: name: tgi-ingress namespace: hf-gke-namespace + # https://cloud.google.com/kubernetes-engine/docs/concepts/ingress + annotations: + kubernetes.io/ingress.class: "gce" spec: - ingressClassName: "gce" rules: - http: paths: