Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cell Population Graphs Y3 cosmetic updates #323

Open
bherr2 opened this issue Jan 4, 2024 · 7 comments
Open

Cell Population Graphs Y3 cosmetic updates #323

bherr2 opened this issue Jan 4, 2024 · 7 comments
Labels
app: cell-population-graphs Cell Population Graphs atomic design: template Templates consist mostly of groups of organisms stitched together to form pages update: cosmetics 💄 Cosmetic UI updates Y3: ds-alignment Align all current UIs cosmetically with the design system

Comments

@bherr2
Copy link
Member

bherr2 commented Jan 4, 2024

The original tissue-bar-graphs web component is written in Angular. We want to integrate this component as an official HRA web component and update it's processing to accept our new cell type summary format (in addition to CSV). More refactoring/ergonomics will likely be needed to make it most useful.

@bherr2 bherr2 added the enhancement A feature enhancement to a current interface label Jan 4, 2024
@bherr2 bherr2 added this to the 2024 FTU Explorer Improvements milestone Jan 4, 2024
@bherr2 bherr2 modified the milestones: 2024 FTU Explorer Improvements, 2024 HRA-UI Issues needing consensus/specs Jan 24, 2024
@bherr2
Copy link
Member Author

bherr2 commented Jan 24, 2024

I'd love to do this now, but it just has to have a spec/disussion to be actionable.

@LibbyUX
Copy link
Contributor

LibbyUX commented Aug 14, 2024

@bherr2,

Is this issue for the app of many names Cell Population Comparison at https://hubmapconsortium.github.io/tissue-bar-graphs/ ? I will organize this issue to the Design System Alignment milestone if so.

@bherr2
Copy link
Member Author

bherr2 commented Aug 14, 2024

Yep!

@LibbyUX LibbyUX self-assigned this Aug 14, 2024
@LibbyUX LibbyUX added product team: designers enhancement A feature enhancement to a current interface atomic design: template Templates consist mostly of groups of organisms stitched together to form pages and removed enhancement A feature enhancement to a current interface labels Aug 14, 2024
@LibbyUX LibbyUX added status: design under review update: cosmetics 💄 Cosmetic UI updates Y3: ds-alignment Align all current UIs cosmetically with the design system app: cell-population-graphs Cell Population Graphs and removed status: needs specification enhancement A feature enhancement to a current interface labels Sep 16, 2024
@LibbyUX LibbyUX changed the title Update and integrate tissue-bar-graph web component Cell Population Graphs Y3 Design System Alignment Sep 19, 2024
@LibbyUX
Copy link
Contributor

LibbyUX commented Sep 19, 2024

@bherr2 are there any notes on this issue that you'd like me to track for later versions of Cell Population Graphs? I realize I kind of took over this issue, lol, so I want to be sure to capture anything for future versions if necessary. Thanks!

@bherr2
Copy link
Member Author

bherr2 commented Sep 20, 2024

One note, is that we will eventually need to make this more flexible (probably a next cycle thing). I think right now you are focusing on rebranding/cleaning up the existing functionality, but for it to be really useful we'll need to think harder about the data model and the types of user interactions with the data that we want to enable with this.

@LibbyUX
Copy link
Contributor

LibbyUX commented Sep 20, 2024

Perfect, I will capture this in a new issue for design system expansion. Thank you so much @bherr2 and happy Friday!

@LibbyUX LibbyUX changed the title Cell Population Graphs Y3 Design System Alignment Cell Population Graphs Y3 cosmetic updates Sep 23, 2024
@LibbyUX
Copy link
Contributor

LibbyUX commented Sep 23, 2024

Ready for dev: Cosmetic updates

The Cell Population Graphs page is ready for development. Our Vega-lite Pattern sheet should be utilized for the visualizations. All design system components relevant to this UI have been submitted or utilized in the past:

Design Notes

  • A new splash section has been added to this UI.
  • We may need a smaller font size for the Vega-lite visualizations. Please contact me when this is being worked on to see if we need to add a smaller font size to our Vega-lite Patterns sheet.
  • Please let me know if you have questions, I am happy to help! Thanks so much!

Figma Resources

image

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app: cell-population-graphs Cell Population Graphs atomic design: template Templates consist mostly of groups of organisms stitched together to form pages update: cosmetics 💄 Cosmetic UI updates Y3: ds-alignment Align all current UIs cosmetically with the design system
Projects
None yet
Development

No branches or pull requests

2 participants