-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cell Population Graphs Y3 cosmetic updates #323
Comments
I'd love to do this now, but it just has to have a spec/disussion to be actionable. |
Is this issue for the app of many names Cell Population Comparison at https://hubmapconsortium.github.io/tissue-bar-graphs/ ? I will organize this issue to the Design System Alignment milestone if so. |
Yep! |
@bherr2 are there any notes on this issue that you'd like me to track for later versions of Cell Population Graphs? I realize I kind of took over this issue, lol, so I want to be sure to capture anything for future versions if necessary. Thanks! |
One note, is that we will eventually need to make this more flexible (probably a next cycle thing). I think right now you are focusing on rebranding/cleaning up the existing functionality, but for it to be really useful we'll need to think harder about the data model and the types of user interactions with the data that we want to enable with this. |
Perfect, I will capture this in a new issue for design system expansion. Thank you so much @bherr2 and happy Friday! |
Ready for dev: Cosmetic updatesThe Cell Population Graphs page is ready for development. Our Vega-lite Pattern sheet should be utilized for the visualizations. All design system components relevant to this UI have been submitted or utilized in the past: Design Notes
Figma Resources |
The original tissue-bar-graphs web component is written in Angular. We want to integrate this component as an official HRA web component and update it's processing to accept our new cell type summary format (in addition to CSV). More refactoring/ergonomics will likely be needed to make it most useful.
The text was updated successfully, but these errors were encountered: