Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve EnumTest to enforce UNKNOWN value for all API enums #1891

Open
bitwiseman opened this issue Jul 1, 2024 · 0 comments
Open

Improve EnumTest to enforce UNKNOWN value for all API enums #1891

bitwiseman opened this issue Jul 1, 2024 · 0 comments
Labels

Comments

@bitwiseman
Copy link
Member

#1885 showed that we haven't been checking the count of all enum values. At the same time I noticed that we do not have UNKNOWN values for all API enum.

Adding new values is not considered a breaking change by GitHub. This has caused hub4j/github-api calls to start failing unexpectedly in the the past - the new value is not recognized and we throw an exception during deserialization. No good.

We need to add UNKNOWN to all enum types that are returned from GitHub and enforce it. The test will include an exclude list to allow enum types only used during sending but not retrieving data.

@bitwiseman bitwiseman added the task label Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant