You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
#1885 showed that we haven't been checking the count of all enum values. At the same time I noticed that we do not have UNKNOWN values for all API enum.
Adding new values is not considered a breaking change by GitHub. This has caused hub4j/github-api calls to start failing unexpectedly in the the past - the new value is not recognized and we throw an exception during deserialization. No good.
We need to add UNKNOWN to all enum types that are returned from GitHub and enforce it. The test will include an exclude list to allow enum types only used during sending but not retrieving data.
The text was updated successfully, but these errors were encountered:
#1885 showed that we haven't been checking the count of all enum values. At the same time I noticed that we do not have
UNKNOWN
values for all APIenum
.Adding new values is not considered a breaking change by GitHub. This has caused
hub4j/github-api
calls to start failing unexpectedly in the the past - the new value is not recognized and we throw an exception during deserialization. No good.We need to add
UNKNOWN
to allenum
types that are returned from GitHub and enforce it. The test will include an exclude list to allowenum
types only used during sending but not retrieving data.The text was updated successfully, but these errors were encountered: