Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is READ_EXTERNAL_STORAGE really needed? #74

Open
rsyring opened this issue Jun 19, 2022 · 1 comment
Open

Is READ_EXTERNAL_STORAGE really needed? #74

rsyring opened this issue Jun 19, 2022 · 1 comment

Comments

@rsyring
Copy link

rsyring commented Jun 19, 2022

I'm not an Android developer so this may be an ignorant post, my apologies if that is the case.

I recently installed the app on a Pixel 6 and was surprised that when requesting READ_EXTERNAL_STORAGE Android said I was granting access to photos and media. That didn't seem like something this app should need.

I did some research and:

  • Looks like Android 11 changed behavior with respect to this permission
  • The permission only grants access to the MediaStore API?
  • I don't see any reference to MediaStore in this source code.
  • I do see a reference to getExternalFilesDir() but in the link above, it looks like no permissions are required to access that API: "Not needed for external storage when your app is used on devices that run Android 4.4 (API level 19) or higher."
@httpdispatch
Copy link
Owner

Thanks for the detailed analysis.

How I remember this optional permission has been added after access forbidden crash started to appear in the Google play console for some devices. That crash appeared when app tried to play selected ringtone. At the time I've assumed that it is some custom ringtone stored at the external storage.
After this permission has been added the crash disappeared from the reports. So I'm still not sure it can be removed without consequences.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants