Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modalWillOpen and modalWillClose events #40

Open
SuhairZain opened this issue Mar 5, 2018 · 0 comments
Open

modalWillOpen and modalWillClose events #40

SuhairZain opened this issue Mar 5, 2018 · 0 comments
Labels
feature

Comments

@SuhairZain
Copy link
Contributor

Hi,
The component has only modalDidOpen and modalDidClose events. Was there any reason to not have modalWillOpen and modalWillClose events? These are useful in some cases.

Also, what about adding events when the scale in animation has completed? This could be useful in cases where we need to calculate the layout/positions of elements within the Modal. We cannot use the modalDidOpen event for this purpose since it's called when the fade in is completed, not the scale.
@httnn httnn added the feature label Mar 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SuhairZain @httnn