Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate the page to be a static-site-generated (SSG) app #103

Closed
htbkoo opened this issue Mar 30, 2022 · 3 comments · Fixed by #112
Closed

Migrate the page to be a static-site-generated (SSG) app #103

htbkoo opened this issue Mar 30, 2022 · 3 comments · Fixed by #112
Assignees

Comments

@htbkoo
Copy link
Owner

htbkoo commented Mar 30, 2022

The app is hosted on GitHub page so I am not sure how to enable server-side-rendering (SSR)

But the page is so simple / static right now so no reason to stay as a client-side-rendering app

@htbkoo htbkoo self-assigned this Mar 30, 2022
@htbkoo htbkoo changed the title Migrate the page to static-site-generated (SSG) Migrate the page to be a static-site-generated (SSG) app Mar 30, 2022
@htbkoo
Copy link
Owner Author

htbkoo commented Apr 4, 2022

Will come back to this and review it again later - seems the migration is more complicated than I had expected initially:

  1. both of the libraries recommended by create-react-app (i.e. react-snapshot or react-snap) are quite out of date and are probably abandoned, e.g.
    1. react-snapshot is even deprecated and recommend using react-snap
    2. But react-snap is not much better either as the last commit was done in more than 2 years ago and there are bunch of issues asking if the project is still active (e.g. Is this package working? stereobooster/react-snap#551, Still active? stereobooster/react-snap#548)
  2. It was mentioned another issue (page load is slower, audit score is lower stereobooster/react-snap#471) that the page loader is slower and audit score is lower when react-snap is used so a more thorough performance testing is needed to confirm the benefits
  3. node-version v12 seems to be incompatible and would need to be dropped at the GitHub Actions CI pipeline (but this would be handled in Upgrade to React v18 #109 anyway)

@htbkoo htbkoo mentioned this issue Apr 14, 2022
13 tasks
@htbkoo
Copy link
Owner Author

htbkoo commented Apr 14, 2022

Note this can be closed by #112 as static-site-generation (SSG) can be done with next export

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant