Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Artist info page: Show wiki editor commentary in separate list from main commentary #568

Open
towerofnix opened this issue Oct 6, 2024 · 0 comments

Comments

@towerofnix
Copy link
Member

As described. This is a spiritual follow-up to #550. Lan, #hsmusic-chat:

Jebb - I kind of feel like you recommended, a while back, that wiki editor commentary be shown separately somehow from normal commentary, on artist pages. I was thinking on exactly those lines earlier today. Since we just recently customized how “edits for wiki” credits are shown (including on artist pages), it feels very within-reach now

The initial suggestion is from Jebb (#hsmusic-chat):

You know, i feel like there should be some sort of visible note or sign about which commentary is wiki editor stuff and which is from the base album
Because you really just can't tell

This precipitated #403 on the same day.

However, it would still be neat to flat-out divide wiki editor commentary from the rest. This sort of division based on annotation is something we're doing now (per #550 linked above), including adapting the artist info page itself. The reasoning is exactly the same - although integrated into the same system (contributions, commentary), they are really different categories of things you as a user want to interact with or explore. That differentiation should be implemented where it counts.

Presentation-wise I think that commentary sections can be left just as they are - it's just the artist info page that should get the division.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant