Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Tracks Referencing Selves/Cycles wiki info field #547

Open
towerofnix opened this issue Aug 7, 2024 · 0 comments
Open

Allow Tracks Referencing Selves/Cycles wiki info field #547

towerofnix opened this issue Aug 7, 2024 · 0 comments

Comments

@towerofnix
Copy link
Member

Branching off hsmusic/hsmusic-data#489 (comment) — Whisper's remarks:

not certain on wiki-side error—if we allow directed cycles (i.e. circles/loops: A refs B, B refs A; #hsmusic-chat), then constraint "no self-referencing" feels inconsistently specialized. better to locate via occasional check in REPL:

> trackData.filter(t => t.referencedTracks.includes(t))
[
  Track "Happy Hospital" (track:happy-hospital) (#40 in Call and New V)
]

mandating acyclic graph via wiki-info.yaml flag would be OK & useful for other wikis (or even as default)—but likely inappropriate for hsmusic-data. could similarly have flag for self-references, allow wikis to customize as desired

# we'd do this in hsmusic-data
# since we don't exactly "prescribe" the meaning of refs
# at the scale of this dataset
Allow Tracks Referencing Selves: true
Allow Tracks Referencing Cycles: true

# if unspecified (e.g. new wikis)
# then you'd get errors as crop-up

As mentioned, the default would be not to allow self/cycle-references.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant