Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Multistream Encoder/Decoder API #59

Open
tortis opened this issue Dec 5, 2024 · 1 comment
Open

Support for Multistream Encoder/Decoder API #59

tortis opened this issue Dec 5, 2024 · 1 comment

Comments

@tortis
Copy link

tortis commented Dec 5, 2024

libopus offers a Multistream API which allows for more channels to be packaged into an opus stream. How difficult would it be to expose those? And is it within the scope of this project?

Thank you!

@tortis
Copy link
Author

tortis commented Dec 5, 2024

I implemented the multistream decoder with a copy-paste job to see if it would work, and it does! for my use-case at least.

https://github.com/musesessions/opus
https://github.com/hraban/opus/compare/v2...musesessions:opus:v2?expand=1

I'm open to contributing a more complete implementation, but I'd like feedback on how it should be done. Is the copy-paste acceptable, or would you prefer the golang Decoder struct to internally handle regular/multistream? If the copy-paste is good, then do you want it in a separate file?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant