Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#463/routes refactor #464

Merged
merged 27 commits into from
Mar 18, 2019
Merged

#463/routes refactor #464

merged 27 commits into from
Mar 18, 2019

Conversation

chrisma
Copy link
Contributor

@chrisma chrisma commented Mar 11, 2019 •
edited
Loading

Addresses #463

chrisma added 16 commits March 11, 2019 15:39
@chrisma
Fix(routes): Use member helper for vm actions
d622af2
@chrisma
Fix(routes): Readd constraint for vm resources
46f04df
@chrisma
Fix(routes): Add scope for Slack routes
a85a479
@chrisma
Fix(routes): Add comment for devise routes config
2a5ab79
@chrisma
Fix(routes): Collapse member block for user resources
8752234
@chrisma
Fix(routes): Remove duplicated root routing, add comment
2bf645b
@chrisma
Fix(routes): Use member block for notification resources
61e641e
@chrisma
Fix(routes): Move reject PATCH into requests resources block
57b2c1c
@chrisma
Fix(routes): Move projects resources near other non-customized resources
f32fb07
@chrisma
Fix(routes): Move unconfigured resources to top of file
9cc2049
@chrisma
Fix(routes): Add OS and request templates resources to 'vms' scope. M…
980c01a 
…ove user resource.
@chrisma
Fix(routes): Move requests resoures into 'vms' scope
a1c6981
@chrisma
Fix(routes): Move 'edit_config' and 'update_config' into 'vms' scope
807d216
@chrisma
Fix(routes): Add '/vms/configs' and '/vms/requests' scopes
b55f605
@chrisma
Fix(routes): Remove redundant params from OS and req. template routes
7acf15c
@chrisma
Refactor(routes): Restructure routes.rb and add explanatory comments
e7f674b
@chrisma chrisma added the WIP work is still in progess for this PR label Mar 11, 2019
@chrisma chrisma mentioned this pull request Mar 12, 2019
Merged
@chrisma chrisma added Review Required and removed WIP work is still in progess for this PR labels Mar 12, 2019
krichly
krichly reviewed Mar 13, 2019
View reviewed changes
config/routes.rb Show resolved Hide resolved
config/routes.rb Show resolved Hide resolved
config/routes.rb Outdated Show resolved Hide resolved
config/routes.rb Outdated Show resolved Hide resolved
config/routes.rb Show resolved Hide resolved
krichly
krichly approved these changes Mar 15, 2019
View reviewed changes
Copy link
Contributor

@krichly krichly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool

bdaase
bdaase approved these changes Mar 16, 2019
View reviewed changes
Copy link
Contributor

@bdaase bdaase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it, makes it much more readable now!

@bdaase
Copy link
Contributor

bdaase commented Mar 16, 2019 •
edited
Loading

One thing I had in mind for a longer time and I get reminded of it in this MR: Why do we not allow to destroy projects? Is there never a point we might have to many of them and they have to be cleaned up?

@chrisma
Copy link
Contributor Author

chrisma commented Mar 18, 2019

Why do we not allow to destroy projects? Is there never a point we might have to many of them and they have to be cleaned up?

Good question. Ticket: #488

@chrisma chrisma merged commit 4ea3cdb into dev Mar 18, 2019
@chrisma chrisma deleted the #463/routes_refactor branch March 18, 2019 14:11
@chrisma chrisma mentioned this pull request Mar 18, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krichly krichly krichly approved these changes

@bdaase bdaase bdaase approved these changes

Assignees
No one assigned
Labels
Review Required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chrisma @bdaase @krichly @code-factor