Added notifications #161
Added notifications #161
Conversation
…ntend # Conflicts: # app/views/layouts/_navbar.html.erb
| <% if user_signed_in? %> | ||
| <form class="form-inline"> | ||
| <% if current_user.contact_requests.any? %> | ||
| <a href="<%= user_contact_requests_path(current_user) %>"> <i class="fa fa-bell" style="color: red; padding: 3px"></i> </a> |
There was a problem hiding this comment.
I would extract all styles into an appropriate css file
There was a problem hiding this comment.
I wouldn't like to do that, because if someone else uses the bell icon, they don't necessarily want my styling...
There was a problem hiding this comment.
Yes but you could use a class like notification-bell or something like that. I just don't like to have HTML, CSS and application logic all in one file 😅 But if you prefer the inline styling that's fine for me because it's not such a big issue 👍
There was a problem hiding this comment.
I agree with @felixauringer. If someone doesn't like the styling, the class can be changed even easier
| @@ -60,6 +60,14 @@ def init | |||
| self.username ||= email.split('@', 2)[0] | |||
| end | |||
|
|
|||
| def has_contact_request? | |||
There was a problem hiding this comment.
| def has_contact_request? | |
| def notifications? |
app/models/user.rb
Outdated
| contact_requests.any? | ||
| end | ||
|
|
||
| def count_contact_requests |
There was a problem hiding this comment.
| def count_contact_requests | |
| def notification_count |
Co-authored-by: Felix Auringer <[email protected]>
Closes #128