-
Notifications
You must be signed in to change notification settings - Fork 11
feature/SC-3505/nexboard #230
base: develop
Are you sure you want to change the base?
Conversation
…cloud/edtrio into feature/SC-3505/Nextboard
@@ -22,5 +27,5 @@ const config = { | |||
}; | |||
|
|||
// eslint-disable-next-line no-console | |||
console.info("config", config); | |||
console.info("config", JSON.stringify(config)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have no proper logger available?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At the moment no. It is log it to the browser console. We will later wrap the logger into a util. But i do not know if we must replace it with any popular logger. It will pass additional kBit to the editor that do not more then the base console logger.
If any error is throw it is pass to the user information, or to sentry send us. But this stuff is not finished, only as prototype.
@@ -18,7 +18,7 @@ | |||
// We need the RAW file from the root dir | |||
// https://github.com/parcel-bundler/parcel/issues/1087#issuecomment-576810737 | |||
const script = document.createElement("script"); | |||
script.setAttribute("src", "env.js"); | |||
script.setAttribute("src", "/env.js"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would this make problems when hosting in a subpath
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. The env.js is placed on the same location like the editor base stuff. But the urls /course/id/... also include in the path if they load the env without /.
addPlugin({ | ||
name: "nxboard", | ||
title: "Nexboard", | ||
description: "Benutze das digitale Nexboard, um all deine Ideen festzuhalten!", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please localize
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
follow up
follow up: https://ticketsystem.schul-cloud.org/browse/SC-3548
Allgemein