Skip to content
This repository has been archived by the owner on Jul 14, 2021. It is now read-only.

feature/SC-3505/nexboard #230

Open
wants to merge 15 commits into
base: develop
Choose a base branch
from
Open

feature/SC-3505/nexboard #230

wants to merge 15 commits into from

Conversation

CeEv
Copy link
Contributor

@CeEv CeEv commented Mar 3, 2020

follow up: https://ticketsystem.schul-cloud.org/browse/SC-3548

Allgemein

@CeEv CeEv changed the title feature/SC-3505/nextboard feature/SC-3505/nexboard Mar 3, 2020
@CeEv CeEv added the WIP work in progress do not merge label Mar 4, 2020
@CeEv CeEv removed the WIP work in progress do not merge label Mar 4, 2020
@CeEv CeEv requested review from Metauriel and janrenz March 6, 2020 09:54
@@ -22,5 +27,5 @@ const config = {
};

// eslint-disable-next-line no-console
console.info("config", config);
console.info("config", JSON.stringify(config));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have no proper logger available?

Copy link
Contributor Author

@CeEv CeEv Mar 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the moment no. It is log it to the browser console. We will later wrap the logger into a util. But i do not know if we must replace it with any popular logger. It will pass additional kBit to the editor that do not more then the base console logger.
If any error is throw it is pass to the user information, or to sentry send us. But this stuff is not finished, only as prototype.

@@ -18,7 +18,7 @@
// We need the RAW file from the root dir
// https://github.com/parcel-bundler/parcel/issues/1087#issuecomment-576810737
const script = document.createElement("script");
script.setAttribute("src", "env.js");
script.setAttribute("src", "/env.js");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would this make problems when hosting in a subpath

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. The env.js is placed on the same location like the editor base stuff. But the urls /course/id/... also include in the path if they load the env without /.

addPlugin({
name: "nxboard",
title: "Nexboard",
description: "Benutze das digitale Nexboard, um all deine Ideen festzuhalten!",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please localize

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

follow up

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants