We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
For timeouts, vsc.util.run.Command.run() checks for the existence of /proc/<pid> for validating the timeout.
vsc.util.run.Command.run()
/proc/<pid>
This is unreliable: proc may not be mounted (under a chroot or with init=/bin/sh) or who knows what else.
proc
init=/bin/sh
The Pythonic way to check for process termination is to call poll():
poll()
p = Popen(["my", "command"]) while p.poll() is None: pass p.terminate() # or p.kill()
Also, commands shouldn't run in subshells by default.
The text was updated successfully, but these errors were encountered:
No branches or pull requests
For timeouts,
vsc.util.run.Command.run()
checks for the existence of/proc/<pid>
for validating the timeout.This is unreliable:
proc
may not be mounted (under a chroot or withinit=/bin/sh
) or who knows what else.The Pythonic way to check for process termination is to call
poll()
:Also, commands shouldn't run in subshells by default.
The text was updated successfully, but these errors were encountered: