From f1d83d32677fd70c6649b6ef1797ecbbf736275c Mon Sep 17 00:00:00 2001 From: James McMullan Date: Tue, 21 May 2024 17:39:37 -0400 Subject: [PATCH] HPCC4J-594 Add support for skipping tests - Updated version of surefire plugin to support excludes file - Added logic to generate an excludes file to GH actions Signed-off-by: James McMullan James.McMullan@lexisnexis.com --- .../workflows/baremetal-regression-suite.yml | 8 +++- .github/workflows/k8s-regression-suite.yml | 8 +++- commons-hpcc/pom.xml | 3 ++ dfsclient/pom.xml | 1 + excluded-tests.txt | 0 pom.xml | 6 ++- wsclient/pom.xml | 1 + ...WsAttributesClientIntegrationTest_620.java | 48 ------------------- .../WsWorkunitsClientIntegration_54_Test.java | 31 ------------ ...WsWorkunitsClientIntegration_620_Test.java | 30 ------------ .../platform/RampsDevRegressionTest.java | 2 + 11 files changed, 26 insertions(+), 112 deletions(-) create mode 100644 excluded-tests.txt delete mode 100644 wsclient/src/test/java/org/hpccsystems/ws/client/WsAttributesClientIntegrationTest_620.java delete mode 100644 wsclient/src/test/java/org/hpccsystems/ws/client/WsWorkunitsClientIntegration_54_Test.java delete mode 100644 wsclient/src/test/java/org/hpccsystems/ws/client/WsWorkunitsClientIntegration_620_Test.java diff --git a/.github/workflows/baremetal-regression-suite.yml b/.github/workflows/baremetal-regression-suite.yml index b46baae07..e9100e8c7 100644 --- a/.github/workflows/baremetal-regression-suite.yml +++ b/.github/workflows/baremetal-regression-suite.yml @@ -176,5 +176,11 @@ jobs: key: ${{ runner.os }}-m2-${{ hashFiles('**/pom.xml') }} restore-keys: ${{ runner.os }}-m2 + - name: Exclude Tests + env: + EXCLUDES: ${{ vars.EXCLUDED_TESTS }} + run: | + echo $EXCLUDES > excluded-tests.txt + - name: Build with Maven - run: mvn -B --activate-profiles jenkins-on-demand -Dmaven.gpg.skip=true -Dmaven.javadoc.skip=true -Dmaven.test.failure.ignore=false -Dhpccconn=http://eclwatch.default:8010 -Dwssqlconn=http://sql2ecl.default:8510 -DHPCC30117=open install + run: mvn -B --activate-profiles jenkins-on-demand -Dmaven.gpg.skip=true -Dmaven.javadoc.skip=true -Dmaven.test.failure.ignore=false -Dhpccconn=http://eclwatch.default:8010 -Dwssqlconn=http://sql2ecl.default:8510 install diff --git a/.github/workflows/k8s-regression-suite.yml b/.github/workflows/k8s-regression-suite.yml index b37ddecba..d7a3e0f35 100644 --- a/.github/workflows/k8s-regression-suite.yml +++ b/.github/workflows/k8s-regression-suite.yml @@ -143,5 +143,11 @@ jobs: key: ${{ runner.os }}-m2-${{ hashFiles('**/pom.xml') }} restore-keys: ${{ runner.os }}-m2 + - name: Exclude Tests + env: + EXCLUDES: ${{ vars.EXCLUDED_TESTS }} + run: | + echo $EXCLUDES > excluded-tests.txt + - name: Build with Maven - run: mvn -B --activate-profiles jenkins-on-demand -Dmaven.gpg.skip=true -Dmaven.javadoc.skip=true -Dmaven.test.failure.ignore=false -Dhpccconn=https://eclwatch.default:8010 -Dwssqlconn=https://sql2ecl.default:8510 -DHPCC30117=open install + run: mvn -B --activate-profiles jenkins-on-demand -Dmaven.gpg.skip=true -Dmaven.javadoc.skip=true -Dmaven.test.failure.ignore=false -Dhpccconn=https://eclwatch.default:8010 -Dwssqlconn=https://sql2ecl.default:8510 install diff --git a/commons-hpcc/pom.xml b/commons-hpcc/pom.xml index 0cb0f4df1..61066112e 100644 --- a/commons-hpcc/pom.xml +++ b/commons-hpcc/pom.xml @@ -27,6 +27,9 @@ maven-surefire-plugin ${maven.surefire.version} + + ../excluded-tests.txt + diff --git a/dfsclient/pom.xml b/dfsclient/pom.xml index cea5897ad..a30fe7484 100644 --- a/dfsclient/pom.xml +++ b/dfsclient/pom.xml @@ -34,6 +34,7 @@ org.hpccsystems.ws.client.TestResultNotifier + ../excluded-tests.txt diff --git a/excluded-tests.txt b/excluded-tests.txt new file mode 100644 index 000000000..e69de29bb diff --git a/pom.xml b/pom.xml index 0a6d9e4f2..8892ae0d0 100644 --- a/pom.xml +++ b/pom.xml @@ -45,7 +45,7 @@ 2.8.2 2.5.2 3.0.2 - 2.22.1 + 3.2.5 4.10.1 1.4 0.1.54 @@ -213,6 +213,7 @@ ${argLine} ${groups} + excluded-tests.txt @@ -433,6 +434,7 @@ ${argLine} ${groups} + excluded-tests.txt @@ -485,6 +487,7 @@ ${argLine} ${groups} + excluded-tests.txt @@ -560,6 +563,7 @@ ${argLine} ${groups} + excluded-tests.txt diff --git a/wsclient/pom.xml b/wsclient/pom.xml index b2e392fe6..fba968c11 100644 --- a/wsclient/pom.xml +++ b/wsclient/pom.xml @@ -88,6 +88,7 @@ org.hpccsystems.ws.client.TestResultNotifier + ../excluded-tests.txt diff --git a/wsclient/src/test/java/org/hpccsystems/ws/client/WsAttributesClientIntegrationTest_620.java b/wsclient/src/test/java/org/hpccsystems/ws/client/WsAttributesClientIntegrationTest_620.java deleted file mode 100644 index 88c0280a6..000000000 --- a/wsclient/src/test/java/org/hpccsystems/ws/client/WsAttributesClientIntegrationTest_620.java +++ /dev/null @@ -1,48 +0,0 @@ -package org.hpccsystems.ws.client; - -import org.hpccsystems.ws.client.wrappers.ArrayOfEspExceptionWrapper; - -public class WsAttributesClientIntegrationTest_620 extends BaseWsAttributesClientIntegrationTest -{ - @Override - public String getHPCCVersion() - { - return "6.2"; - } - - @Override - public String getThorClusterName() - { - return "dev_thor"; - } - - @Override - public String getRoxieClusterName() - { - return "roxie"; - } - - @Override - public String getHthorClusterName() - { - return "hthor"; - } - - @Override - public void testWriteAttributes() throws Exception, ArrayOfEspExceptionWrapper - { - super.testWriteAttributes(); - } - - @Override - public void testWriteSingleAttribute() throws Exception, ArrayOfEspExceptionWrapper - { - super.testWriteSingleAttribute(); - } - - @Override - public void testInvalidAttributes() throws Exception - { - super.testInvalidAttributes(); - } -} diff --git a/wsclient/src/test/java/org/hpccsystems/ws/client/WsWorkunitsClientIntegration_54_Test.java b/wsclient/src/test/java/org/hpccsystems/ws/client/WsWorkunitsClientIntegration_54_Test.java deleted file mode 100644 index 477c27940..000000000 --- a/wsclient/src/test/java/org/hpccsystems/ws/client/WsWorkunitsClientIntegration_54_Test.java +++ /dev/null @@ -1,31 +0,0 @@ -package org.hpccsystems.ws.client; - -public class WsWorkunitsClientIntegration_54_Test extends BaseWsWorkunitsClientIntegrationTest -{ - String hpccver="5.4"; - - @Override - public void confirmPlatform() throws Exception - { - if (platform.getVersion().toString().startsWith(hpccver)) - throw new Exception("Cannot run 5.4 tests against HPCC cluster on '" + platform.getIP() + "' version: '" + platform.getVersion().toString() + "'"); - } - - @Override - public String getThorClusterName() - { - return "hthor_qa"; - } - - @Override - public String getRoxieClusterName() - { - return "roxie_bair_qa_01"; - } - - @Override - public String getHthorClusterName() - { - return "hthor_qa"; - } -} diff --git a/wsclient/src/test/java/org/hpccsystems/ws/client/WsWorkunitsClientIntegration_620_Test.java b/wsclient/src/test/java/org/hpccsystems/ws/client/WsWorkunitsClientIntegration_620_Test.java deleted file mode 100644 index a938a3f55..000000000 --- a/wsclient/src/test/java/org/hpccsystems/ws/client/WsWorkunitsClientIntegration_620_Test.java +++ /dev/null @@ -1,30 +0,0 @@ -package org.hpccsystems.ws.client; - -public class WsWorkunitsClientIntegration_620_Test extends BaseWsWorkunitsClientIntegrationTest -{ - String hpccver="6.2"; - @Override - protected void confirmPlatform() throws Exception - { - if (platform.getVersion().toString().startsWith(hpccver)) - throw new Exception("Cannot run 6.2 tests against HPCC cluster on '" + platform.getIP() + "' version: '" + platform.getVersion().toString() + "'"); - } - - @Override - public String getThorClusterName() - { - return "thor"; - } - - @Override - public String getRoxieClusterName() - { - return "roxie"; - } - - @Override - public String getHthorClusterName() - { - return "hthor"; - } -} diff --git a/wsclient/src/test/java/org/hpccsystems/ws/client/platform/RampsDevRegressionTest.java b/wsclient/src/test/java/org/hpccsystems/ws/client/platform/RampsDevRegressionTest.java index 312b15ce0..828b544b1 100644 --- a/wsclient/src/test/java/org/hpccsystems/ws/client/platform/RampsDevRegressionTest.java +++ b/wsclient/src/test/java/org/hpccsystems/ws/client/platform/RampsDevRegressionTest.java @@ -6,9 +6,11 @@ import org.hpccsystems.ws.client.wrappers.ArrayOfEspExceptionWrapper; import org.hpccsystems.ws.client.wrappers.wsdfu.DFUDataColumnWrapper; +import org.junit.Ignore; import org.junit.Test; import org.junit.experimental.categories.Category; +@Ignore @Category(org.hpccsystems.commons.annotations.IntegrationTests.class) public class RampsDevRegressionTest extends EclParseRegressionTest {