From cf89f712d7568392b21da2096b7cf9d231afe4e8 Mon Sep 17 00:00:00 2001 From: Anthony Fishbeck Date: Mon, 2 Oct 2023 16:31:26 -0400 Subject: [PATCH] review update 2 Signed-off-by: Anthony Fishbeck --- common/pkgfiles/referencedfilelist.cpp | 4 ++-- helm/hpcc/values.schema.json | 4 ++++ 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/common/pkgfiles/referencedfilelist.cpp b/common/pkgfiles/referencedfilelist.cpp index 36532fdc40a..6779afd0538 100644 --- a/common/pkgfiles/referencedfilelist.cpp +++ b/common/pkgfiles/referencedfilelist.cpp @@ -378,12 +378,12 @@ void ReferencedFile::processForeignFileTree(const IPropertyTree *tree, const cha } } -StringBuffer &makeRemoteLFN(StringBuffer &remoteLfn, const char *remoteStorageName, const char *remotePrefix, const char *lfn) +static StringBuffer &makeRemoteLFN(StringBuffer &remoteLfn, const char *remoteStorageName, const char *remotePrefix, const char *lfn) { if (isEmptyString(remoteStorageName)) return remoteLfn; remoteLfn.append("remote::").append(remoteStorageName).append("::"); - if (remotePrefix && *remotePrefix) + if (!isEmptyString(remotePrefix)) remoteLfn.append(remotePrefix).append("::"); return remoteLfn.append(lfn); } diff --git a/helm/hpcc/values.schema.json b/helm/hpcc/values.schema.json index 5525f1916c2..7b088157966 100644 --- a/helm/hpcc/values.schema.json +++ b/helm/hpcc/values.schema.json @@ -1456,6 +1456,10 @@ }, "hpa": { "$ref": "#/definitions/hpa" + }, + "expert": { + "description": "Custom internal options usually reserved for internal testing", + "type": "object" } } },