From 744c85b4f76f1cf0108e418a2ce93a16acfec349 Mon Sep 17 00:00:00 2001 From: Jake Smith Date: Thu, 23 Nov 2023 18:42:39 +0000 Subject: [PATCH] HPCC-30913 Ensure Thor logging/tracing overrides are generated Signed-off-by: Jake Smith --- helm/hpcc/templates/thor.yaml | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/helm/hpcc/templates/thor.yaml b/helm/hpcc/templates/thor.yaml index 321de033991..a9601571590 100644 --- a/helm/hpcc/templates/thor.yaml +++ b/helm/hpcc/templates/thor.yaml @@ -28,11 +28,11 @@ Pass in dict with root and me {{- define "hpcc.thorConfigMap" -}} {{- $eclAgentType := .me.eclAgentType | default "hthor" }} {{- $hthorName := printf "%s-%s" .me.name $eclAgentType }} -{{- $eclAgentScope := dict "name" .eclAgentName "type" $eclAgentType "useChildProcesses" .eclAgentUseChildProcesses "replicas" .eclAgentReplicas "maxActive" .me.maxJobs | merge (pick .me "keepJobs") }} -{{- $thorAgentScope := dict "name" .thorAgentName "replicas" .thorAgentReplicas "maxActive" .me.maxGraphs | merge (pick .me "keepJobs") }} +{{- $eclAgentScope := dict "name" .eclAgentName "type" $eclAgentType "useChildProcesses" .eclAgentUseChildProcesses "replicas" .eclAgentReplicas "maxActive" .me.maxJobs | merge (pick .me "keepJobs" "logging" "tracing") }} +{{- $thorAgentScope := dict "name" .thorAgentName "replicas" .thorAgentReplicas "maxActive" .me.maxGraphs | merge (pick .me "keepJobs" "logging" "tracing") }} {{- $eclAgentResources := .me.eclAgentResources | default dict -}} -{{- $hthorScope := dict "name" $hthorName "jobMemorySectionName" "eclAgentMemory" | merge (pick .me "multiJobLinger" "maxGraphStartupTime") | merge (dict "resources" (deepCopy $eclAgentResources)) }} -{{- $thorScope := omit .me "eclagent" "thoragent" "hthor" "logging" "env" "eclAgentResources" "eclAgentUseChildProcesses" "eclAgentReplicas" "thorAgentReplicas" "eclAgentType" }} +{{- $hthorScope := dict "name" $hthorName "jobMemorySectionName" "eclAgentMemory" | merge (pick .me "multiJobLinger" "maxGraphStartupTime" "logging" "tracing") | merge (dict "resources" (deepCopy $eclAgentResources)) }} +{{- $thorScope := omit .me "eclagent" "thoragent" "hthor" "env" "eclAgentResources" "eclAgentUseChildProcesses" "eclAgentReplicas" "thorAgentReplicas" "eclAgentType" }} {{- $misc := .root.Values.global.misc | default dict }} {{- $postJobCommand := $misc.postJobCommand | default "" }} {{- $eclAgentJobName := printf "%s-job-_HPCC_JOBNAME_" $eclAgentType }} @@ -49,21 +49,21 @@ data: {{ $thorScope.name }}.yaml: version: 1.0 thor: -{{ toYaml $thorScope | indent 6 }} +{{ toYaml (omit $thorScope "logging" "tracing") | indent 6 }} {{- include "hpcc.generateLoggingConfig" (dict "root" .root "me" $thorScope) | indent 6 }} {{ include "hpcc.generateVaultConfig" . | indent 6 }} {{ $eclAgentType }}: # hthor or roxie -{{ toYaml $hthorScope | indent 6 }} +{{ toYaml (omit $hthorScope "logging" "tracing") | indent 6 }} platform: type: "thor" width: {{ mul ($thorScope.numWorkers | default 1) ( $thorScope.channelsPerWorker | default 1) }} {{- include "hpcc.generateLoggingConfig" (dict "root" .root "me" $hthorScope ) | indent 6 }} {{ include "hpcc.generateVaultConfig" . | indent 6 }} eclagent: # main agent Q handler -{{ toYaml $eclAgentScope | indent 6 }} +{{ toYaml (omit $eclAgentScope "logging" "tracing") | indent 6 }} {{- include "hpcc.generateLoggingConfig" (dict "root" .root "me" $eclAgentScope) | indent 6 }} thoragent: # Thor graph handler -{{ toYaml $thorAgentScope | indent 6 }} +{{ toYaml (omit $thorAgentScope "logging" "tracing") | indent 6 }} {{- include "hpcc.generateLoggingConfig" (dict "root" .root "me" $thorAgentScope) | indent 6 }} type: thor global: