Skip to content

Commit

Permalink
fix
Browse files Browse the repository at this point in the history
  • Loading branch information
flybird11111 committed Sep 10, 2024
1 parent 30527ab commit 214b912
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions colossalai/booster/plugin/hybrid_parallel_plugin.py
Original file line number Diff line number Diff line change
Expand Up @@ -1090,7 +1090,7 @@ def __init__(
self.custom_policy = custom_policy
assert zero_stage in (0, 1, 2)
if self.pp_size > 1:
assert pp_style in ["1f1b", "interleaved", "zbv"], "Unsupported pipeline parallelism style"
assert pp_style in ["1f1b", "interleaved"], "Unsupported pipeline parallelism style"
assert pp_style == "interleaved" or num_model_chunks == 1, "num_model_chunks must be 1 when using 1f1b"
assert (
num_microbatches is not None or microbatch_size is not None
Expand Down Expand Up @@ -1123,8 +1123,6 @@ def __init__(
microbatch_size=microbatch_size,
enable_metadata_cache=enable_metadata_cache,
)
elif pp_style == "zbv":
assert num_model_chunks == 1, "number of model chunks must equal 2 when using zbv"
else:
raise NotImplementedError()
if sequence_parallelism_mode == "ring_attn":
Expand Down

0 comments on commit 214b912

Please sign in to comment.