Fix a bug for fractional weeks caused by strftime() returning a week … #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…number of zero for days that fall before the first Monday of the year. The impact of the bug was that no commits would be found for that particular week (i.e. '2016-0'). The fix is to use isocalendar(), which lines the weeks/years up such that all weeks are seven days long, irrespective of where the fall with respect to the new year.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…number of zero for days that fall before the first Monday of the year. The impact of the bug was that no commits would be found for that particular week (i.e. '2016-0'). The fix is to use isocalendar(), which lines the weeks/years up such that all weeks are seven days long, irrespective of where they fall relative to the new year.