Adds a Sender::factory_timeout method. #214
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in response to issue #211.
By allowing timeouts to be set for the factory, and also adding an option to enable a client to keep running with no connections, we make it possible for a client which has become disconnected for any reason (or was even unable to connect in the first place) to make repeated connection attempts.
A timeout can be set in connection_lost (using a Sender from the outgoing Handler, which is unfortunate, but perhaps unavoidable) and then a new connection can be created in the (newly added) on_timeout method of the factory.